remove hard-coded namespace from noobaa

[yati1998]

this commit removes the hard-coded namespace
for noobaa collection to collect all the
resources in correct namespace

[black-dragon74]

Hi @yati1998

I guess lines 68 and 77 needs updating as well (maybe moved into for block)?

odf-must-gather/collection-scripts/gather_noobaa_resources

Line 68 in 5daf367

for pod in $(oc -n "${ns}" get pods -l "${NOOBAA_POSTGRES_LABEL}" | grep -v NAME | awk '{print $1}'); do

odf-must-gather/collection-scripts/gather_noobaa_resources

Line 77 in 5daf367

NOOBAA_RECONCILE_STRATEGY=$(oc -n "${ns}" get storagecluster -o jsonpath='{.items[0].spec.multiCloudGateway.reconcileStrategy}' 2>/dev/null)

What is the value of ns supposed to be here? Was it wrongly interpreted all this time?

P.S: The INSTALL_NAMESPACE changes LGTM. Just pointing out what I stumbled across while reviewing.

Regards

[agarwal-mudit]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[agarwal-mudit]

@black-dragon74 @yati1998 Can this PR be merged?

[agarwal-mudit]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[black-dragon74]

@black-dragon74 @yati1998 Can this PR be merged?

Sure, I have opened a new issue to track the changes that I requested on this PR :)

[black-dragon74]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [black-dragon74,yati1998]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@agarwal-mudit: new pull request created: #225

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@agarwal-mudit: new pull request created: #226

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.