ci: fix detection of GH actions extra disk #569
Conversation
The 'extra' block device attached to GH actions runners has changed size twice in 3 months. The previous strategy of detecting the disk by size is becoming harder to maintain. Additionally, the block size with recent changes (75G) is now the same as the boot device (also 75G), making the method inexact. The method can now be summarized as, "find the boot disk and choose the disk that isn't the boot disk to be the 'extra' one used." Prior to this, we used a one-liner based on `lsblk`. While we could still make this a one-liner, the method is now updated to 2 effective lines, plus debug text output to stderr to help if we need to debug further in the future. Of note, the 'extra' disk has a mount point of "/mnt", but it is unclear whether this is a reliable heuristic for detecting the extra disk. For years now, GH action runners have had only 2 disks. Therefore, it seems slightly more likely that a heuristic to "choose the non-boot disk" will be a more robust long-term solution. If this strategy proves to be unreliable in the future, it may be wise to consider whether "the device with a partition mounted to '/mnt'" would be a good alternative. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com> (cherry picked from commit feacb64)
This PR fixes the failure while running multicluster mirroring CI tests Signed-off-by: sp98 <sapillai@redhat.com> (cherry picked from commit 45adae1)
this kernal version is greater than 5.11 let's use mounter kernal instead of fuse. Signed-off-by: subhamkrai <srai@redhat.com> (cherry picked from commit abc272c)
|
@subhamkrai: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@subhamkrai: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Merging this even without a BZ since it is blocking other downstream fixes from being merged, and it only affects stabilizing the CI, and not the product. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhamkrai, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Description of your changes:
The CI was broken upstream and downstream due to changes in the extra disk used by OSDs. These fixes are needed so we can stabilize the CI and even allow for merging any downstream PRs.
Checklist:
skip-cion the PR.