build: export ROOK_IMAGE env variable #598
Conversation
Nikhil-Ladha
force-pushed
the
add-rook-image-env-variable
branch
2 times, most recently
from
a9f64e2 to
39e7562
Compare
Update script to export ROOK_IMAGE env variable so that it can be updated with custom values during the build Signed-off-by: Nikhil-Ladha <[email protected]>
add generated changes for csv Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
add-rook-image-env-variable
branch
from
39e7562 to
1398c5a
Compare
|
/retest |
| @@ -429,7 +429,7 @@ metadata: | |||
| } | |||
| ] | |||
| relatedImages: | |||
| - image: docker.io/rook/ceph:master | |||
| - image: rook/ceph:master | |||
There was a problem hiding this comment.
| - image: rook/ceph:master | |
| - image: rook/ceph:master |
it was copied from what ocs-operator had any issue with previously or it is just an improvement
There was a problem hiding this comment.
Just an improvement, technically all these updates were handled by the csv-merger tool in ocs-operator. But, here we are updating via sed command so made it similar to the other image field used in deployement spec such that both the fields are updated during the csv-gen.
| @@ -1863,7 +1863,7 @@ metadata: | |||
| name: rook-ceph-operator.v4.15.0 | |||
| namespace: placeholder | |||
| relatedImages: | |||
| - image: docker.io/rook/ceph:master | |||
| - image: docker.io/rook/ceph:v1.13.0.399.g9c0d795e2 | |||
There was a problem hiding this comment.
| - image: docker.io/rook/ceph:v1.13.0.399.g9c0d795e2 | |
| - image: rook/ceph:v1.13.0.399.g9c0d795e2 |
seems like this also needs to be updated?
There was a problem hiding this comment.
This is the result of above update. This keeps the container image and relatedImages field same in the csv
There was a problem hiding this comment.
@Nikhil-Ladha I see this in related images image: rook/ceph:master which is not same as above.
There was a problem hiding this comment.
Yeah, that's the placeholder.
The actual value is updated via the gen-csv file. over here: https://github.com/red-hat-storage/rook/blob/master/build/csv/csv-gen.sh#L53
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Based on this comment #599 (comment) seems like we are good with the PR |
|
@sp98 can you please review this PR? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nikhil-Ladha, sp98, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update script to export ROOK_IMAGE env variable so that it can be updated with custom values during the build
Checklist: