-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all the csi env #599
Add all the csi env #599
Conversation
Skipping CI for Draft Pull Request. |
I have tested this locally. The CSI sidecars are properly being overloaded but none of the other images are, i.e. these images still ignore the env variables:
Weirdly, the ceph image disappeared from the relatedImages altogether. It is only available in the EDIT:
|
a98b49b
to
591dab7
Compare
@b-ranto I tested locally by passing the env var in the terminal and it worked may due wrong relatedImage it was not working not sure. Could you try again? |
I have re-tested it and it works fine now. It turned out we were missing authetntication and that is why the three images above failed. |
good to know it worked |
once #598 is merged will mark this ready for review |
add all the csi related images version in csv which ocs-operator csv merger tool was changing. Signed-off-by: subhamkrai <[email protected]>
591dab7
to
fb3be9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fb3be9a
to
183d94f
Compare
pushed without any modification to make commitlint happy |
these are auto generated csv changes when run `make gen-csv`. Signed-off-by: subhamkrai <[email protected]>
183d94f
to
0382944
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: b-ranto, Nikhil-Ladha, sp98, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
build: add all the csi image version in csv
add all the csi related images version in csv which
ocs-operator csv merger tool was changing.
build: These are auto-generated csv changes
these are auto-generated csv changes when run
make gen-csv
.Checklist: