csv: Update csv version #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Ladha
force-pushed
the
update-csv-version
branch
from
3dec3dd to
9327b2f
Compare
subhamkrai
requested changes
May 15, 2024
There was a problem hiding this comment.
@Nikhil-Ladha can you also cherry-pick commit rook@f21f3f5 currently the auto sync pr is on hold #645 (comment)
update rook csv version to 4.17 Signed-off-by: Nikhil-Ladha <[email protected]>
Add generated changes for csv Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
update-csv-version
branch
from
9327b2f to
767060e
Compare
subhamkrai
reviewed
May 17, 2024
| CSV_VERSION="${CSV_VERSION:-${DEFAULT_CSV_VERSION}}" | ||
| SKIP_RANGE="${SKIP_RANGE:-""}" | ||
| REPLACES_CSV_VERSION="${REPLACES_CSV_VERSION:-""}" | ||
| LATEST_ROOK_IMAGE="docker.io/rook/ceph:v1.13.0.399.g9c0d795e2" | ||
| ROOK_IMAGE=${ROOK_IMAGE:-${LATEST_ROOK_IMAGE}} | ||
| DEFAULT_BUNDLE_IMAGE=rook/rook-ceph-operator-bundle:"${VERSION}" | ||
| DEFAULT_BUNDLE_IMAGE=quay.io/ocs-dev/rook-ceph-operator-bundle:"${VERSION}" |
There was a problem hiding this comment.
Suggested change
| DEFAULT_BUNDLE_IMAGE=quay.io/ocs-dev/rook-ceph-operator-bundle:"${VERSION}" | |
| DEFAULT_BUNDLE_IMAGE=quay.io/ocs-dev/rook-ceph-operator-bundle:"${VERSION}" |
Why this change?
There was a problem hiding this comment.
The default location for the image is quay.io now, compared to docker.io/rook what we discussed when the bundle image was created. So, updated it now.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nikhil-Ladha, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rook csv version, also updated the default rook bundle image.