Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv: Update csv version #650

Merged
merged 2 commits into from
May 20, 2024
Merged

csv: Update csv version #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461787f
csv: update rook csv version
Nikhil-Ladha May 15, 2024
767060e
csv: add generated changes for csv
Nikhil-Ladha May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ export GOOS
GOOS=$(go env GOOS)
export GOARCH
GOARCH=$(go env GOARCH)
DEFAULT_CSV_VERSION="4.16.0"
DEFAULT_CSV_VERSION="4.17.0"
CSV_VERSION="${CSV_VERSION:-${DEFAULT_CSV_VERSION}}"
SKIP_RANGE="${SKIP_RANGE:-""}"
REPLACES_CSV_VERSION="${REPLACES_CSV_VERSION:-""}"
LATEST_ROOK_IMAGE="docker.io/rook/ceph:v1.13.0.399.g9c0d795e2"
ROOK_IMAGE=${ROOK_IMAGE:-${LATEST_ROOK_IMAGE}}
DEFAULT_BUNDLE_IMAGE=rook/rook-ceph-operator-bundle:"${VERSION}"
DEFAULT_BUNDLE_IMAGE=quay.io/ocs-dev/rook-ceph-operator-bundle:"${VERSION}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEFAULT_BUNDLE_IMAGE=quay.io/ocs-dev/rook-ceph-operator-bundle:"${VERSION}"
DEFAULT_BUNDLE_IMAGE=quay.io/ocs-dev/rook-ceph-operator-bundle:"${VERSION}"

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default location for the image is quay.io now, compared to docker.io/rook what we discussed when the bundle image was created. So, updated it now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh only for bundle image right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

BUNDLE_IMAGE="${BUNDLE_IMAGE:-${DEFAULT_BUNDLE_IMAGE}}"

function ver() {
Expand Down
4 changes: 2 additions & 2 deletions build/csv/ceph/rook-ceph-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,7 +1863,7 @@ metadata:
ciBhcyBvc0VycjoKICAgICAgICBwcmludChmIkVycm9yIHdoaWxlIHRyeWluZyB0byBvdXRwdXQg
dGhlIGRhdGE6IHtvc0Vycn0iKQogICAgZmluYWxseToKICAgICAgICByak9iai5zaHV0ZG93bigp
Cg==
name: rook-ceph-operator.v4.16.0
name: rook-ceph-operator.v4.17.0
namespace: placeholder
spec:
apiservicedefinitions: {}
Expand Down Expand Up @@ -3387,7 +3387,7 @@ spec:
provider:
name: Red Hat
url: https://www.redhat.com
version: 4.16.0
version: 4.17.0
minKubeVersion: 1.16.0
relatedImages:
- image: docker.io/rook/ceph:v1.13.0.399.g9c0d795e2
Expand Down
Loading