Add RHDH skills volume support to LCORE container - #351
Conversation
Signed-off-by: Stephanie <yangcao@redhat.com>
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
| cat > "${TEMP_DIR}/fetch-lightspeed-skills-init.json" <<EOF | ||
| { | ||
| "name": "fetch-lightspeed-skills", | ||
| "image": "quay.io/redhat-ai-dev/utils:latest", |
There was a problem hiding this comment.
Do we need to use utils image for this, or is there a really small image we can use that has git that could do the job?
There was a problem hiding this comment.
I use quay.io/redhat-ai-dev/utils:latest because it is already used by this workflow, and provides Git and Bash. This avoids introducing another third-party image. I’m happy to switch if we have a preferred approved lightweight Git image.
There was a problem hiding this comment.
I'm good with keeping it as utils for now, maybe something we can revisit when we onboard to the newer rhdh chart that lets us natively add the volumes?
|
Latest commit
|
What does this PR do?
PR title
Add RHDH skills volume support to LCORE
Summary
emptyDirvolume for RHDH skills.quay.io/redhat-ai-dev/utils:latestto fetch themainbranch ofredhat-developer/rhdh-skills.skills/contents into the shared volume./app-root/skillsinlightspeed-core.Testing
bash tests/helm/test-skills-volume.shhelm lint charts/rhdh --set okp.enabled=falsegit diff --checkNo new LCORE image or long-running sidecar is introduced.
Which issue(s) does this PR fix
https://redhat.atlassian.net/browse/RHIDP-16676
How to test changes / Special notes to the reviewer