Skip to content

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 9, 2026

  • pin setuptools<82 in pyproject.toml because passlib still uses pkg_resources which was removed in setuptools 82
  • fix ruff linting errors in rero_ils/theme/menus.py by wrapping multi-line lambda expressions in parentheses
  • fix ruff linting error in tests/api/selfcheck/test_models.py by using pytest.raises as a context manager
  • remove resolved CVE-2025-53000 (nbconvert) exception from scripts/test
  • update uv.lock

* pin setuptools<82 in pyproject.toml because passlib still uses
  pkg_resources which was removed in setuptools 82
* fix ruff linting errors in rero_ils/theme/menus.py by wrapping
  multi-line lambda expressions in parentheses
* fix ruff linting error in tests/api/selfcheck/test_models.py by
  using pytest.raises as a context manager
* remove resolved CVE-2025-53000 (nbconvert) exception from
  scripts/test
* update uv.lock

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep self-assigned this Feb 9, 2026
@github-actions github-actions bot added the developers From a developer point of view. label Feb 9, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Walkthrough

Adds setuptools version constraint (below 82), wraps lambda expressions in menu configuration with parentheses for clarity, removes CVE-2025-53000 from test prechecks, and refactors pytest assertion to context manager style.

Changes

Cohort / File(s) Summary
Dependency constraints
pyproject.toml
Adds setuptools (<82) version constraint with comment noting pkg_resources removal in setuptools 82.
Code formatting
rero_ils/theme/menus.py
Wraps visible_when lambda expressions with parentheses for enhanced readability; no functional changes.
Test and script updates
scripts/test, tests/api/selfcheck/test_models.py
Removes CVE-2025-53000 exception from test prechecks; refactors pytest.raises from function-style to context manager syntax.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: pinning setuptools and fixing ruff linting errors across multiple files.
Description check ✅ Passed The description is clearly related to the changeset, detailing each modification including setuptools constraint, ruff fixes, CVE removal, and lock file update.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
pyproject.toml (1)

95-96: Reasonable workaround, but consider tracking the upstream fix.

The pin is a valid mitigation for passlib's reliance on the removed pkg_resources. Consider adding a link to the relevant passlib issue (or a TODO) so this constraint can be removed once passlib drops its pkg_resources dependency or is replaced.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Coverage Status

coverage: 92.038%. remained the same
when pulling a0e49e1 on rerowep:wep-dependencies-setuptools
into 4e9cd81 on rero:staging.

@PascalRepond PascalRepond merged commit 8bef0bf into rero:staging Feb 9, 2026
6 checks passed
@rerowep rerowep deleted the wep-dependencies-setuptools branch February 9, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developers From a developer point of view.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants