Fix 2280 by moving the bootstrap 3 classes out of SchemaField #4579
Conversation
|
@heath-freenome Should we keep the |
Fixed #2280 by moving marker classes from `SchemaField` to `WrapIfAdditionalTemplate` - In `@rjsf/utils`, updated `WrapIfAdditionalTemplateProps` to pick up the `hideError` and `rawErrors` props from `FieldTemplateProps` - In `@rjsf/core`, updated `SchemaField` to move the `form-group` and `field` marker classes to the `WrapIfAdditionalTemplate` - Also moved the `field-error`, `has-error` and `has-danger` error marker classes - Updated the grid snapshot due to the change - Updated the snapshots in other themes due to the removed marker classes - Updated the `CHANGELOG_v6.md` and `v6x upgrade guide.md` to reflect these changes
heath-freenome
force-pushed
the
fix-2280
branch
from
0533113 to
10c6efd
Compare
@nickgros Hmmm, probably... I wonder if I should also keep the |
heath-freenome
changed the title
| icon='copy' | ||
| /> | ||
| ); | ||
| return <IconButton title={translateString(TranslatableString.CopyButton)} {...props} icon='copy' />; |
There was a problem hiding this comment.
These are added in the ArrayFieldItemButtonsTemplate
| @@ -68,7 +76,7 @@ export default function WrapIfAdditionalTemplate< | |||
| <div className='col-xs-2'> | |||
| <RemoveButton | |||
| id={buttonId<T>(id, 'remove')} | |||
| className='array-item-remove btn-block' | |||
| className='rjsf-object-property-remove btn-block' | |||
There was a problem hiding this comment.
This one was wrong, it's for an object not array
| @@ -79,7 +79,7 @@ export default function RatingWidget< | |||
| }; | |||
|
|
|||
| return ( | |||
| <div className='field field-array'> | |||
| <> | |||
There was a problem hiding this comment.
We didn't need these
There was a problem hiding this comment.
Looks like the fragment can be removed
| const validateFns = superSchemaFns as unknown as ValidatorFunctions; | ||
| const validateOptionsFns = superSchemaOptionsFns as unknown as ValidatorFunctions; |
There was a problem hiding this comment.
Fixed a build error in chakra-ui with this
Reasons for making this change
Fixed #2280 by moving marker classes from
SchemaFieldtoWrapIfAdditionalTemplate@rjsf/utils, updatedWrapIfAdditionalTemplatePropsto pick up thehideErrorandrawErrorsprops fromFieldTemplateProps@rjsf/core, updatedSchemaFieldto move theform-groupclass to theWrapIfAdditionalTemplatehas-errorandhas-dangererror classesrjsf-CHANGELOG_v6.mdandv6x upgrade guide.mdto reflect these changesChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.