Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ANYmal D description #97

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Add ANYmal D description #97

merged 2 commits into from
Mar 6, 2025

Conversation

stephane-caron
Copy link
Member

@stephane-caron stephane-caron commented Jul 24, 2024

There is an issue loading this description in yourdfpy:

  ======================================================================
  ERROR: test_anymal_d_description (test_yourdfpy.TestYourdfpy)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/tests/loaders/test_yourdfpy.py", line 32, in test
      load_robot_description(description)
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/robot_descriptions/loaders/yourdfpy.py", line 45, in load_robot_description
      return yourdfpy.URDF.load(module.URDF_PATH, mesh_dir=module.PACKAGE_PATH)
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/yourdfpy/urdf.py", line 989, in load
      return URDF(robot=URDF._parse_robot(xml_element=xml_root), **kwargs)
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/yourdfpy/urdf.py", line 641, in __init__
      self._scene = self._create_scene(
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/yourdfpy/urdf.py", line 1335, in _create_scene
      self._add_geometries_to_scene(
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/yourdfpy/urdf.py", line 1269, in _add_geometries_to_scene
      new_s = self._geometry2trimeshscene(
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/yourdfpy/urdf.py", line 1240, in _geometry2trimeshscene
      new_s = new_s.scaled(geometry.mesh.scale)
    File "/home/runner/work/robot_descriptions.py/robot_descriptions.py/.tox/loader-yourdfpy/lib/python3.9/site-packages/trimesh/scene/scene.py", line 1084, in scaled
      geometry = geometries[group[0]]
  IndexError: index 0 is out of bounds for axis 0 with size 0

@coveralls
Copy link

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 13701348273

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.515%

Totals Coverage Status
Change from base Build 13701165554: 0.02%
Covered Lines: 981
Relevant Lines: 1006

💛 - Coveralls

@stephane-caron stephane-caron force-pushed the add/anymal_d_description branch from 2ba929d to 400f96a Compare March 6, 2025 14:39
@stephane-caron stephane-caron enabled auto-merge (rebase) March 6, 2025 14:50
@stephane-caron stephane-caron merged commit ee47739 into main Mar 6, 2025
15 checks passed
@stephane-caron stephane-caron deleted the add/anymal_d_description branch March 6, 2025 14:53
@stephane-caron
Copy link
Member Author

The issue was related to yourdfpy or trimesh and has been fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants