Initial skeleton for libroc #7575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhansconnect
reviewed
Feb 4, 2025
Comment on lines
+72
to
+73
| // don't include a lot of extra symbols | ||
| .optimize = .ReleaseSmall, |
There was a problem hiding this comment.
Please don't do this. Leave it to the default optimization target.
| const mem = std.mem; | ||
| const Allocator = std.mem.Allocator; | ||
|
|
||
| export fn roc_check(path: *const c_char) i32 { |
There was a problem hiding this comment.
If we make a full featured lib roc, we should probably make main.zig strictly build roc via the same interfaces as libroc. That ensures they stay in sync.
That said, I'm not sold we want a full featured lib roc. I think we likely want a super small shim lib roc that only has the ability to interact with the intepreter.
|
Closing as I agree it's maybe too early... we should discuss the design further. |
|
Useful thoughts for future reference https://roc.zulipchat.com/#narrow/channel/395097-compiler-development/topic/zig.20compiler.20-.20calling.20roc/near/497305962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion...