Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial skeleton for libroc #7575

Closed
wants to merge 1 commit into from
Closed

Initial skeleton for libroc #7575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ pub fn build(b: *std.Build) void {
.{ .name = "cli", .module = b.createModule(.{ .root_source_file = b.path("src/cli.zig") }) },
},
);

const libroc = b.addStaticLibrary(.{
.name = "roc",
.root_source_file = b.path("src/lib.zig"),
.target = target,
// don't include a lot of extra symbols
.optimize = .ReleaseSmall,
Comment on lines +72 to +73
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. Leave it to the default optimization target.

});

b.installArtifact(libroc);
}

fn add_fuzz_target(
Expand Down
11 changes: 11 additions & 0 deletions src/lib.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const std = @import("std");
const mem = std.mem;
const Allocator = std.mem.Allocator;

export fn roc_check(path: *const c_char) i32 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we make a full featured lib roc, we should probably make main.zig strictly build roc via the same interfaces as libroc. That ensures they stay in sync.

That said, I'm not sold we want a full featured lib roc. I think we likely want a super small shim lib roc that only has the ability to interact with the intepreter.


// TODO implement `roc check` for libroc
_ = path;

return 0;
}