Skip to content

GravityCompensation: Use the FilterTest fixture #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

christophfroehlich
Copy link
Contributor

I applied the same changes of #261 to the GravityCompensation filter test. Fixes #385

@christophfroehlich christophfroehlich added the backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 jazzy. label Aug 1, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.65%. Comparing base (c46e3c5) to head (66357f1).

Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #439      +/-   ##
===============================================
- Coverage        77.75%   77.65%   -0.10%     
===============================================
  Files               30       29       -1     
  Lines             2009     1996      -13     
  Branches           125      124       -1     
===============================================
- Hits              1562     1550      -12     
  Misses             379      379              
+ Partials            68       67       -1     
Flag Coverage Δ
unittests 77.65% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...test/control_filters/test_gravity_compensation.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 608f56a into ros2-master Aug 13, 2025
22 of 24 checks passed
@christophfroehlich christophfroehlich deleted the fix/gravity branch August 13, 2025 18:49
mergify bot pushed a commit that referenced this pull request Aug 13, 2025
christophfroehlich added a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit 608f56a)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 jazzy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout of test_gravity_compensation
3 participants