Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robnux_arm_kinematics_trajectory repo. #44353

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

guanfengliu
Copy link

Please Add This Package to be indexed in the rosdistro.

robnux_arm_kinematics_trajectory

The source is here:

https://github.com/ROBNUX/robnux_arm_kinematics_trajectory.git

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

added robnux_arm_kinematics_trajectory repo.
Added arm_kinematics_trajectory repo. that contains libraries and tool for robotic arm planning and control
@guanfengliu guanfengliu requested a review from Yadunund as a code owner February 3, 2025 07:41
@github-actions github-actions bot added noetic Issue/PR is for the ROS 1 Noetic distribution rolling Issue/PR is for the ROS 2 Rolling distribution labels Feb 3, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@mjcarroll
Copy link
Member

Holding for Rolling sync

@mjcarroll mjcarroll added the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 3, 2025
@guanfengliu
Copy link
Author

Don't know why rosdistro validation failed? I generated 1.0.0 release tag in https://github.com/ROBNUX/arm_kinematics_trajectory. But don't know how to retrigger pipeline.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for rolling. The same applies to noetic.

rolling/distribution.yaml Outdated Show resolved Hide resolved
rolling/distribution.yaml Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@guanfengliu
Copy link
Author

Left comments for rolling. The same applies to noetic.
Addressed. Thanks.

@guanfengliu guanfengliu requested a review from Yadunund February 5, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold noetic Issue/PR is for the ROS 1 Noetic distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants