Kilted #5514
Open
Kilted #5514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+194
to
+195
|
|
||
| <license>Apache-2.0</license> |
There was a problem hiding this comment.
I would just remove these lines to keep it simple:
Suggested change
| <license>Apache-2.0</license> |
| @@ -186,6 +186,15 @@ For that to work, the ``__init__`` code has to be changed to: | |||
|
|
|||
| self.timer = self.create_timer(1, self.timer_callback) | |||
|
|
|||
| Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future. | |||
There was a problem hiding this comment.
Suggested change
| Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future. | |
| Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future: |
3 tasks
fujitatomoya
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the instruction to add optional dependency in package.xml for ros2/kilted_tutorial_party#536