Skip to content

Kilted #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: kilted
Choose a base branch
from
Open

Kilted #5514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4275fe6
updated the document to add optional dependency in package.xml
Tenveis May 3, 2025
a50f397
Merge branch `ros2:kilted` into kilted
Tenveis May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,15 @@ For that to work, the ``__init__`` code has to be changed to:

self.timer = self.create_timer(1, self.timer_callback)

Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future.
Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future:


.. code-block:: xml

# ...

<license>Apache-2.0</license>
Comment on lines +194 to +195
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove these lines to keep it simple:

Suggested change
<license>Apache-2.0</license>

<depend>rclpy</depend>
<depend>rcl_interfaces</depend>

The rest of the code remains the same.
Once you run the node, you can then run ``ros2 param describe /minimal_param_node my_parameter`` to see the type and description.
Expand Down