Add Rails 6.1 tests to matrix strategy #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Perry Hertler <[email protected]>
Co-authored-by: Perry Hertler <[email protected]>
Co-authored-by: Perry Hertler <[email protected]>
perryqh
approved these changes
Nov 22, 2023
| @@ -3,5 +3,5 @@ | |||
| # | |||
| # Examples: | |||
| # | |||
| # movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) | |||
| # Character.create(name: 'Luke', movie: movies.first) | |||
| # movies = Movie.create([{ name: "Star Wars" }, { name: "Lord of the Rings" }]) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a Rails 6.1 test fixture app alongside the existing Rails 7.0 one, extended the
require_test_rails_applicationspec helper to accept the Rails version as an argument which defaults to theRAILS_VERSIONenvironment variable. I then modified the matrix test strategy in.github/workflows/ci.ymlto run the test suite againstRAILS_VERSION=6.1andRAILS_VERSION=7.0for each of the different Ruby versions we test against.If the
RAILS_VERSIONenv var is not set, Rails 7.0 is used as the default.