Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 6.1 tests to matrix strategy #72

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Add Rails 6.1 tests to matrix strategy #72

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88da1b8
ran 'rails _6.1_ new test_app' and renamed
schoblaska Nov 21, 2023
076f9e1
copy app and packs directory from rails 7 test app
schoblaska Nov 21, 2023
af0dae4
run 'bundle' in rails 6.1 test app
schoblaska Nov 21, 2023
9b7b114
move specs to shared examples and run against two versions of rails
schoblaska Nov 21, 2023
545fe59
get rails version from env var; only run specs once
schoblaska Nov 21, 2023
f7f84d6
add rails versions to github actions matrix strategy
schoblaska Nov 21, 2023
507d8a4
move rails version env var check to helper signature
schoblaska Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/fixtures/rails-6.1/app/assets/stylesheets/application.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
* This is a manifest file that'll be compiled into application.css, which will include all the files
* listed below.
*
* Any CSS and SCSS file within this directory, lib/assets/stylesheets, or any plugin's
* Any CSS (and SCSS, if configured) file within this directory, lib/assets/stylesheets, or any plugin's
* vendor/assets/stylesheets directory can be referenced here using a relative path.
*
* You're free to add application-wide styles to this file and they'll appear at the bottom of the
* compiled file so the styles you add here take precedence over styles defined in any other CSS/SCSS
* compiled file so the styles you add here take precedence over styles defined in any other CSS
* files in this directory. Styles in this file should be added after the last require_* statement.
* It is generally better to create a new file per style scope.
*
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/rails-6.1/app/models/application_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
class ApplicationRecord < ActiveRecord::Base
self.abstract_class = true
primary_abstract_class
end
3 changes: 1 addition & 2 deletions spec/fixtures/rails-6.1/app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
<%= csrf_meta_tags %>
<%= csp_meta_tag %>

<%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %>
<%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
<%= stylesheet_link_tag "application" %>
</head>

<body>
Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/rails-6.1/db/seeds.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
#
# Examples:
#
# movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }])
# Character.create(name: 'Luke', movie: movies.first)
# movies = Movie.create([{ name: "Star Wars" }, { name: "Lord of the Rings" }])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨

# Character.create(name: "Luke", movie: movies.first)
6 changes: 6 additions & 0 deletions spec/fixtures/rails-6.1/packs/pants/jeans/app/models/pants/jeans/bootcut.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module Pants
module Jeans
class Bootcut
end
end
end
3 changes: 3 additions & 0 deletions spec/fixtures/rails-6.1/packs/pants/jeans/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
metadata:
engine: true
engine_name: pants/jeans
Empty file added spec/fixtures/rails-6.1/packs/pants/package.yml
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions spec/fixtures/rails-6.1/packs/pants/shorts/app/models/shorts/zipper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Shorts
class Zipper
end
end
4 changes: 4 additions & 0 deletions spec/fixtures/rails-6.1/packs/pants/shorts/app/services/shorts/khaki.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Shorts
class Khaki
end
end
4 changes: 4 additions & 0 deletions spec/fixtures/rails-6.1/packs/pants/shorts/app/services/shorts/linen.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Shorts
class Linen
end
end
2 changes: 2 additions & 0 deletions spec/fixtures/rails-6.1/packs/pants/shorts/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
metadata:
engine: true
Empty file added spec/fixtures/rails-6.1/packs/shirts/app/models/shirts/pocket.rb
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions spec/fixtures/rails-6.1/packs/shirts/app/services/shirts/long_sleeve.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Shirts
class LongSleeve
end
end
4 changes: 4 additions & 0 deletions spec/fixtures/rails-6.1/packs/shirts/app/services/shirts/short_sleeve.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Shirts
class ShortSleeve
end
end
Empty file added spec/fixtures/rails-6.1/packs/shirts/package.yml
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions spec/fixtures/rails-6.1/packs/shoes/app/services/shoes/flip_flops.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Shoes
class FlipFlops
end
end
2 changes: 2 additions & 0 deletions spec/fixtures/rails-6.1/packs/shoes/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
metadata:
engine: true