-
Notifications
You must be signed in to change notification settings - Fork 39
feat: add issue template for changes #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
0243555
7e5b00e
9c1b945
cefd25d
505331a
439b1ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| # SPDX-License-Identifier: MIT OR Apache-2.0 | ||
| # SPDX-FileCopyrightText: The Rust Project Developers | ||
|
|
||
| name: Change | ||
| description: File a change for the FLS | ||
| title: "[Change]: " | ||
| labels: ["change intake"] | ||
| assignees: | ||
| - PLeVasseur | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Thank you for contributing a change! | ||
| - type: input | ||
| id: title | ||
| attributes: | ||
| label: Change description | ||
| description: Description of what is intended to be changed | ||
| placeholder: Fix description of lexing due to xx | ||
| validations: | ||
| required: true | ||
| - type: dropdown | ||
| id: area | ||
| attributes: | ||
| label: Area | ||
| description: Which part of the language does this fall under? | ||
| options: | ||
| - ABI | ||
| - async / await | ||
| - attributes | ||
| - closures | ||
| - conditional compilation | ||
| - const evaluation | ||
| - conventions | ||
| - destructors | ||
| - diagnostics | ||
| - "edition: 2015" | ||
| - "edition: 2018" | ||
| - "edition: 2021" | ||
| - "edition: 2024" | ||
| - editions | ||
| - generics | ||
| - glossary | ||
| - grammar | ||
| - inline assembly | ||
| - linkage | ||
| - macros | ||
| - method call | ||
| - panic | ||
| - patterns | ||
| - proc macros | ||
| - resolution (names, paths, namespaces, preludes, ...) | ||
| - types | ||
| - type inference | ||
| - type layout | ||
| - undefined behavior | ||
| - N/A | ||
| validations: | ||
| required: true | ||
| - type: dropdown | ||
| id: category | ||
| attributes: | ||
| label: Category | ||
| description: What kind of change is this? | ||
| options: | ||
| - Bug | ||
| - Formatting | ||
| - Improvement to Non-Prose Section | ||
| - Language Cleanup | ||
| - New Content | ||
| - Other | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: fls-id | ||
| attributes: | ||
| label: FLS Paragraph ID | ||
| description: | | ||
| The Paragraph ID from the FLS corresponding to what this Guideline covers. | ||
| Easiest way to obtain this is to navigate to the | ||
| [FLS](https://rust-lang.github.io/fls), right click a section ID | ||
| (e.g. `4.2:2`), inspect, and then find it in the pane which opens in | ||
| your browser. | ||
|
Comment on lines
+79
to
+84
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As an aside, perhaps this points toward us wanting to expose these identifiers more readily on the front-end.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, agreed. I think something like display on hover over the section numbering would be really nice.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Opened an issue for it: #586 |
||
|
|
||
| **Note**: New content need not fill this in. | ||
| placeholder: fls_69zyas59o8ff | ||
PLeVasseur marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| id: change-description | ||
| attributes: | ||
| label: Change description (extended) | ||
| description: | | ||
| A longer description of the intended change, including background and | ||
| details on in what way the FLS is improved by the change. | ||
| placeholder: Fix description of lexing due to xx, since under conditions yy it's possible for zz to occur. | ||
| validations: | ||
| required: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # SPDX-License-Identifier: MIT OR Apache-2.0 | ||
| # SPDX-FileCopyrightText: The Rust Project Developers | ||
|
|
||
| blank_issues_enabled: true |
Uh oh!
There was an error while loading. Please reload this page.