Rename scalar_prod and scalar_sum to product and sum #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner314
force-pushed
the
rename-scalar-ops
branch
from
37fe22b to
aa9768e
Compare
jturner314
changed the title
|
I think that |
|
product is good. Good to avoid scalar_prod, that's just a confusion point vs the dot product. 🙂 |
bluss
reviewed
Oct 28, 2018
jturner314
force-pushed
the
rename-scalar-ops
branch
from
8a5f631 to
9f5f5bb
Compare
bluss
approved these changes
Nov 4, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scalar_prodmethod hasn't been released yet, so we can freely rename it. The oldscalar_summethod now has adeprecatedannotation, which causes a warning when building code that uses it and is visible in the docs.See also this comment from @bluss.