Skip to content

Bump netlink-packet-utils to v0.6.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

qmonnet
Copy link
Contributor

@qmonnet qmonnet commented Apr 2, 2025

Bump netlink-packet-utils version to v0.6.0. No functional change.

The motivation is to eventually get rid of older dependencies: duplicated versions of thiserror and unmaintained crate paste (see rust-netlink/netlink-packet-utils#20 (comment) for more context).

The commit bumps the version for netlink-packet-utils, and adjusts error handling accordingly. Note that I'm not 100% sure I handled the errors correctly (at least it builds and tests still pass), so let me know if there are some more adjustments required.

Note: I thought of creating a version bump commit in the same PR, but I see this one needs to go first if we want the right commit SHA in the changelog.

@cathay4t
Copy link
Member

cathay4t commented Apr 2, 2025

Let's only bump version on release commit.

cathay4t
cathay4t previously approved these changes Apr 2, 2025
@cathay4t cathay4t dismissed their stale review April 2, 2025 10:48

CI is not happy.

@cathay4t
Copy link
Member

cathay4t commented Apr 2, 2025

Please fix the CI failure

@qmonnet qmonnet force-pushed the pr/bump-netlink-packet-utils branch from 8b5f0f7 to c10ff1c Compare April 2, 2025 10:53
@qmonnet
Copy link
Contributor Author

qmonnet commented Apr 2, 2025

My bad - formatting should be fixed, now.

@cathay4t
Copy link
Member

cathay4t commented Apr 2, 2025

The CI failure is caused by rate limit of codecov which is safe to ignore. Force merging.

@cathay4t cathay4t merged commit 01e8dd1 into rust-netlink:main Apr 2, 2025
2 of 3 checks passed
@cathay4t
Copy link
Member

cathay4t commented Apr 2, 2025

@qmonnet Thanks for the contribution! Could you also fix netlink-packet-core?

@qmonnet
Copy link
Contributor Author

qmonnet commented Apr 2, 2025

Yes! Coming next, today or tomorrow.

@qmonnet qmonnet deleted the pr/bump-netlink-packet-utils branch April 2, 2025 13:00
@qmonnet
Copy link
Contributor Author

qmonnet commented Apr 2, 2025

Thinking about this:

Thanks for the contribution! Could you also fix netlink-packet-core?

I suppose you meant netlink-packet-route right? (That's how I understood it the first time, at least).

Before I update netlink-packet-route, could we do a release on netlink-packet-core, so that I can bump both netlink-packet-core and netlink-packet-utils in netlink-packet-route, without having to pull two different versions of nelink-packet-utils as dependencies (one as a direct dep, the other as a dep for -core)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants