Skip to content

Bump netlink-packet-utils to v0.6.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ description = "netlink packet types"
[dependencies]
anyhow = "1.0.31"
byteorder = "1.3.2"
netlink-packet-utils = "0.5.2"
netlink-packet-utils = "0.6.0"

[dev-dependencies]
netlink-packet-route = "0.13.0"
8 changes: 4 additions & 4 deletions src/done.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ impl Emitable for DoneMessage {
}
}

impl<'buffer, T: AsRef<[u8]> + 'buffer> Parseable<DoneBuffer<&'buffer T>>
for DoneMessage
{
fn parse(buf: &DoneBuffer<&'buffer T>) -> Result<DoneMessage, DecodeError> {
impl<T: AsRef<[u8]>> Parseable<DoneBuffer<&T>> for DoneMessage {
type Error = DecodeError;

fn parse(buf: &DoneBuffer<&T>) -> Result<DoneMessage, Self::Error> {
Ok(DoneMessage {
code: buf.code(),
extended_ack: buf.extended_ack().to_vec(),
Expand Down
10 changes: 4 additions & 6 deletions src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,10 @@ impl Emitable for ErrorMessage {
}
}

impl<'buffer, T: AsRef<[u8]> + 'buffer> Parseable<ErrorBuffer<&'buffer T>>
for ErrorMessage
{
fn parse(
buf: &ErrorBuffer<&'buffer T>,
) -> Result<ErrorMessage, DecodeError> {
impl<T: AsRef<[u8]>> Parseable<ErrorBuffer<&T>> for ErrorMessage {
type Error = DecodeError;

fn parse(buf: &ErrorBuffer<&T>) -> Result<ErrorMessage, Self::Error> {
// FIXME: The payload of an error is basically a truncated packet, which
// requires custom logic to parse correctly. For now we just
// return it as a Vec<u8> let header: NetlinkHeader = {
Expand Down
8 changes: 4 additions & 4 deletions src/header.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ impl Emitable for NetlinkHeader {
}
}

impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NetlinkBuffer<&'a T>>
for NetlinkHeader
{
fn parse(buf: &NetlinkBuffer<&'a T>) -> Result<NetlinkHeader, DecodeError> {
impl<T: AsRef<[u8]> + ?Sized> Parseable<NetlinkBuffer<&T>> for NetlinkHeader {
type Error = DecodeError;

fn parse(buf: &NetlinkBuffer<&T>) -> Result<NetlinkHeader, Self::Error> {
Ok(NetlinkHeader {
length: buf.length(),
message_type: buf.message_type(),
Expand Down
32 changes: 16 additions & 16 deletions src/message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use std::fmt::Debug;

use anyhow::Context;
use netlink_packet_utils::DecodeError;

use crate::{
Expand Down Expand Up @@ -83,40 +82,41 @@ where
}
}

impl<'buffer, B, I> Parseable<NetlinkBuffer<&'buffer B>> for NetlinkMessage<I>
impl<B, I> Parseable<NetlinkBuffer<&B>> for NetlinkMessage<I>
where
B: AsRef<[u8]> + 'buffer,
B: AsRef<[u8]>,
I: NetlinkDeserializable,
{
fn parse(buf: &NetlinkBuffer<&'buffer B>) -> Result<Self, DecodeError> {
type Error = DecodeError;

fn parse(buf: &NetlinkBuffer<&B>) -> Result<Self, Self::Error> {
use self::NetlinkPayload::*;

let header =
<NetlinkHeader as Parseable<NetlinkBuffer<&'buffer B>>>::parse(buf)
.context("failed to parse netlink header")?;
<NetlinkHeader as Parseable<NetlinkBuffer<&B>>>::parse(buf)?;

let bytes = buf.payload();
let payload = match header.message_type {
NLMSG_ERROR => {
let msg = ErrorBuffer::new_checked(&bytes)
.and_then(|buf| ErrorMessage::parse(&buf))
.context("failed to parse NLMSG_ERROR")?;
.and_then(|buf| ErrorMessage::parse(&buf))?;
Error(msg)
}
NLMSG_NOOP => Noop,
NLMSG_DONE => {
let msg = DoneBuffer::new_checked(&bytes)
.and_then(|buf| DoneMessage::parse(&buf))
.context("failed to parse NLMSG_DONE")?;
.and_then(|buf| DoneMessage::parse(&buf))?;
Done(msg)
}
NLMSG_OVERRUN => Overrun(bytes.to_vec()),
message_type => {
let inner_msg = I::deserialize(&header, bytes).context(
format!("Failed to parse message with type {message_type}"),
)?;
InnerMessage(inner_msg)
}
message_type => match I::deserialize(&header, bytes) {
Err(e) => {
return Err(DecodeError::Other(
format!("Failed to parse message with type {message_type}: {e}").into()),
);
}
Ok(inner_msg) => InnerMessage(inner_msg),
},
};
Ok(NetlinkMessage { header, payload })
}
Expand Down
Loading