-
-
Notifications
You must be signed in to change notification settings - Fork 748
Clarify 2descent deprecation #41429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Clarify 2descent deprecation #41429
Conversation
|
please undo the change in projective_space. I am removing the full function in another PR |
|
@fchapoton > please undo the change in projective_space. I am removing the full function in another PR Thanks — done. Appreciate the coordination. |
|
note that error messages, by a python convention, should not start with a capital and should not end with a dot |
|
@fchapoton > note that error messages, by a python convention, should not start with a capital and should not end with a dot Good catch, thanks. I’ve updated the deprecation messages so they follow Python’s convention (lowercase, no trailing dot). |
|
you forgot to change 'this method" to "this function" in functional.py. Please be more careful. |
|
@fchapoton > you forgot to change 'this method" to "this function" in functional.py. Please be more careful. Thanks for catching that — sorry about the oversight. |
|
Now you changed both error messages.. Please stop doing so many wrong things. Are you a real person or a slop-producer ? |
|
@fchapoton > Now you changed both error messages.. Please stop doing so many wrong things. Are you a real person or a slop-producer ? Sorry about that — you’re right. |
Summary
This pull request improves the clarity of a deprecation warning in the elliptic
curve 2-descent implementation (
gp_simon.py). The previous warning messagewas vague and did not clearly state what users should do instead. This PR updates
the message to explicitly indicate the correct replacement: using the
2-descent algorithm over ℚ via PARI.
Background
The function currently emits the warning:
This phrasing is ambiguous and informal:
Clear and precise deprecation messages are important because they guide users
in updating their code correctly and reduce confusion in interactive and
doctest output.
What is changed
The deprecation call