Skip to content

Clarify 2descent deprecation #41429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vishwas-droid wants to merge 10 commits into from
+4 −3
Closed

Clarify 2descent deprecation #41429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8fb835b
Clarify deprecation message for krull_dimension
vishwas-droid Jan 10, 2026
2d8ff53
Clarify deprecation message for 2-descent algorithm
vishwas-droid Jan 10, 2026
cf3489e
Clarify deprecation message for is_ProjectiveSpace
vishwas-droid Jan 10, 2026
be0a2c3
Revert projective_space deprecation change (function removed upstream)
vishwas-droid Jan 10, 2026
7ec959a
Update functional.py
vishwas-droid Jan 11, 2026
ce6c6e9
Update gp_simon.py
vishwas-droid Jan 11, 2026
3836857
Update gp_simon.py
vishwas-droid Jan 11, 2026
3a829cf
Update functional.py
vishwas-droid Jan 11, 2026
0befd71
Update gp_simon.py
vishwas-droid Jan 11, 2026
a28940f
Update gp_simon.py
vishwas-droid Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sage/misc/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,8 @@ def krull_dimension(x):
sage: U.krull_dimension()
4
"""
deprecation(39311, "please use the krull_dimension method")
deprecation(39311, "this function is deprecated; use `krull_dimension()` instead")

return x.krull_dimension()


Expand Down
4 changes: 2 additions & 2 deletions src/sage/schemes/elliptic_curves/gp_simon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ def simon_two_descent(E, verbose=0, lim1=None, lim3=None, limtriv=None,
K_pari = pari.bnfinit(K.polynomial(), 1)
known_points = [P.change_ring(to_K) for P in known_points]
else:
deprecation(38461, "please use the 2-descent algorithm over QQ inside pari")
from_K = lambda x: x
deprecation(39311, "this method is deprecated; use `krull_dimension()` instead")
from_K = lambda x: x

# The block below mimics the defaults in Simon's scripts.
# They need to be changed when these are updated.
Expand Down