Skip to content

api/exec await + latex #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 20, 2024
Merged

api/exec await + latex #7722

merged 35 commits into from
Aug 20, 2024

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Jul 30, 2024

Description

  • coming up with the right semantics to start, get and await an async job

  • using this to enhance latex document compilation. this is way harder than I hoped for :-( ... the more I debug, the more problems come to the surface.

    • the hardest bug was a case, where a process that exits in a forced way (e.g. kill) has no exit code. Then, the backend never returns, leaving the callback chain hanging. So, this is now fixed, because the exit code falls back to 0 in that case.
  • this fixes simple tikz error causes latex build to hang with no easy way to kill running latex job (problem is that you can't easily kill it) #3783 by letting users click a stop button if there is no progress

    Here is how this looks after >15 seconds. Of course, there is no indication why. The log stops and cpu is high. More informative than before.

    Screenshot from 2024-08-09 18-20-27

  • after compilation is done, this adds peak known memory usage and duration at the top of the logs.

    Screenshot from 2024-08-09 18-24-16

Checklist:

  • Testing instructions are provided, if not obvious
  • Release instructions are provided, if not obvious

@haraldschilly haraldschilly force-pushed the api-exec-await branch 4 times, most recently from 5747662 to 8738f1b Compare August 5, 2024 14:43
@haraldschilly haraldschilly force-pushed the api-exec-await branch 3 times, most recently from 0d31762 to ff62e0a Compare August 9, 2024 16:34
@haraldschilly haraldschilly changed the title api/exec await api/exec await + latex Aug 13, 2024
@haraldschilly haraldschilly marked this pull request as ready for review August 13, 2024 13:56
@haraldschilly
Copy link
Contributor Author

This is by far not perfect, but it is definitely a step forward.

@haraldschilly haraldschilly merged commit 3023103 into master Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant