Skip to content

Add all solutions to errors in CoreError.java#3402

Draft
josh-wong wants to merge 1 commit into
masterfrom
add-solutions-to-core-errors-all
Draft

Add all solutions to errors in CoreError.java#3402
josh-wong wants to merge 1 commit into
masterfrom
add-solutions-to-core-errors-all

Conversation

@josh-wong
Copy link
Copy Markdown
Member

@josh-wong josh-wong commented Mar 6, 2026

Description

This PR includes all error solutions in CoreError.java. These solutions, which were reviewed in batches in PRs that target this branch, help users understand how to resolve or further investigate the errors, improving debuggability and user support.

Note

To avoid having these error solutions become a blocker if we need to release a minor or patch version, the error solutions are being reviewed on child branches that target this branch. After all PRs for error solutions for CoreError.java have been merged, we can merge this branch into the master branch.

Related issues and/or PRs

Changes made

  • Added solutions to all errors in CoreError.java.
  • Applied Spotless formatting to those error solutions.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Added solutions to errors in CoreError.java.

@josh-wong josh-wong self-assigned this Mar 6, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a comprehensive set of error solutions into CoreError.java. These solutions, developed and reviewed in stages, aim to provide clearer guidance for resolving or investigating errors, thereby significantly improving the user's debugging experience.

Highlights

  • Error Solutions Added: Incorporated all previously reviewed error solutions into CoreError.java to enhance debuggability and user support.
  • Code Formatting: Applied Spotless formatting to the newly added error solutions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • core/src/main/java/com/scalar/db/common/CoreError.java
    • Corrected hyphenation in error messages for Db2 and Oracle cross-partition scan operations.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces minor typographical fixes in two error messages within CoreError.java, changing 'cross partition' to the hyphenated 'cross-partition' for consistency. The changes are correct. However, the pull request title and description state that this change adds solutions for all errors, which is not reflected in the provided diff. A review comment has been added to highlight this discrepancy and suggest aligning the PR's metadata with its content.

Comment thread core/src/main/java/com/scalar/db/common/CoreError.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants