Add solutions to errors 10000 to 10093 in CoreError.java#3403
Add solutions to errors 10000 to 10093 in CoreError.java#3403josh-wong wants to merge 6 commits into
CoreError.java#3403Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds helpful solution messages to a range of error codes in CoreError.java. The solutions are clear and provide good guidance for users. I've found a minor inconsistency in the use of "clustering key" versus "clustering-key" between the error messages and the newly added solution texts, which I've detailed in a specific comment. Overall, this is a valuable improvement for debuggability.
| "0042", | ||
| "Invalid ID specified. ID: %d", | ||
| "", | ||
| "Use a valid transaction state ID."), |
There was a problem hiding this comment.
@brfrn169 I'm wondering how users can handle this error. Maybe this should not be a USER_ERROR?
| "The storage does not support mutations across multiple partitions. Storage: %s; Mutations: %s", | ||
| "", | ||
| ""), | ||
| "Group mutations by partition key and execute them in separate transactions, or use a storage that supports multi-partition mutations."), |
There was a problem hiding this comment.
@brfrn169 I don't think we document the atomicity unit we apply for each storage. It is helpful for performance optimization, so documenting it might be nice. What do you think?
| "", | ||
| ""), | ||
| "Use only EQ, NE, IS_NULL, or IS_NOT_NULL operators for BLOB columns in Cosmos DB conditions."), | ||
| INVALID_CONSISTENCY_LEVEL( |
There was a problem hiding this comment.
This error message is only used for CosmosDB, and since the solution is only applicable to Cosmos. I think we might as well rename the error to be Cosmos DB-specific rather than storage-agnostic.
| INVALID_CONSISTENCY_LEVEL( | |
| COSMOS_INVALID_CONSISTENCY_LEVEL( |
There was a problem hiding this comment.
Just to confirm, are we OK to make this change here now? Or will changing it affect other source code?
There was a problem hiding this comment.
It will affect another Java file. Since it is a small change, I think it's fine to make it here.
There was a problem hiding this comment.
Understood, thanks! I've addressed it in a28db84.
| "Storage not found. Storage: %s", | ||
| "", | ||
| "Verify the storage name is defined in your multi-storage configuration."), | ||
| JDBC_SQLITE_NAMESPACE_NAME_NOT_ACCEPTABLE( |
There was a problem hiding this comment.
@brfrn169
The error and the one below are raised when the table or namespace names contain a $ character, which is used internally to separate the namespace from the table in the table name, such as MY_NAMESPACE$MY_TABLE
Should we mention directly in the error message that this $ is not allowed ? Otherwise, I think the error message is not very helpful.
Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
Change `INVALID_CONSISTENCY_LEVEL` to `COSMOS_INVALID_CONSISTENCY_LEVEL`. Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
4 participants
Description
This PR adds error solutions to errors 10000 to 10093 in
CoreError.java. These solutions help users understand how to resolve or further investigate the errors, improving debuggability and user support.Note
As previously discussed, since we have a lot of errors within the five classes in
CoreError.java, I've included only a portion of the solutions in this PR. Later PRs will include similar portions, with the last error solution in each PR ending on a topic (in this case, before the Consensus Commit–related error messages).Related issues and/or PRs
CoreError.java#3402Note
To avoid having the batches of error solutions become a blocker if we need to release a minor or patch version, this branch targets a parent branch for the
CoreError.javaerror solutions. After all PRs for error solutions forCoreError.javahave been merged, we can merge that branch into the master branch.Changes made
CoreError.java.Checklist
Additional notes (optional)
Since this PR covers only a portion of the error solutions, the parent PR for the
CoreError.javasolutions mentioned above will include a release note.Release notes
N/A