Accept JDBC connection string starting with "jdbc:spanner" used by Spanner Omni#3559
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the RdbEngineFactory to recognize the jdbc:spanner JDBC URL prefix, enabling support for Spanner Omni. A review comment suggests appending a trailing colon to the new prefix to maintain consistency with other database protocols and prevent potential false matches.
Torch3333
force-pushed
the
accept_spanner_jdbc_con_str
branch
from
5b99a95 to
15fb890
Compare
Torch3333
requested review from
a team,
KodaiD,
brfrn169,
Copilot,
feeblefakie and
komamitsu
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ScalarDB’s JDBC engine selection to recognize Spanner JDBC URLs that start with jdbc:spanner: (used by Spanner Omni), in addition to the existing jdbc:cloudspanner: prefix, so Spanner connections aren’t rejected based solely on URL scheme.
Changes:
- Extend
RdbEngineFactoryURL prefix matching to treatjdbc:spanner:as Spanner. - Keep Spanner engine selection behavior unchanged otherwise (still routes to
RdbEngineSpanner).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Torch3333
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google Cloud Spanner uses a JDBC connection string starting with
jdbc:cloudspanner:but Spanner Omni documentation uses a connection string starting withjdbc:spanner:. Currently, ScalarDB only accepts the former and rejects the latter. This PR makes sure both connection string patterns are accepted.Note
Using a
jdbc:cloudspanner:connection string with Spanner Omni is possible.Related issues and/or PRs
Changes made
jdbc:spanner:as a valid connection string pattern for Spanner.Checklist
Additional notes (optional)
N/A
Release notes
Accepts connection string starting with
jdbc:spannerto connect to Spanner (emulator, omni, and cloud instance) in addition to the already supportedjdbc:cloudspannerpattern.