This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Fix: lost tx_type when doing type conversion #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenfeizhang
pushed a commit
that referenced
this pull request
Aug 2, 2023
lispc
added a commit
that referenced
this pull request
Aug 4, 2023
…s for the dummy chunk proofs to avoid dummy chunk proofgen time (#712) * partiall address review comments of #670 * disable disable_proof_agg by default * fix soundness issues with data hash * add fixed cells for chunk_is_valid * fix typo * well... need morning coffee * typo in readme * fix soundness issue in is_smaller_than * [feat] unify u8 u16 lookup table (#694) * add range table * replace Range256Table of rlp_circuit_fsm * replace u16_table of tx_circuit * use TableColumn * add type alias * use type alias * annotate lookup column * opt min_num_rows_block in poseidon_circuit (#700) prune debug prints and lint * speedup ci using verify_at_rows (#703) * speedup ci using verify_at_rows * use verify_at_rows to speedup super circuit ci tests * update super circuit row estimation API (#695) * remove num_of_chunks in aggregation circuit's instance column (#704) Co-authored-by: kunxian xia <[email protected]> * fix: lost tx_type when doing type conversion (#710) * fix condition (#708) * gates for zero checks * statement 1 is correct * reenable statements 3,6,7 * reenable statement 4 * everything seems to work again * update aggregation test accordingly * update spec * minor clean up * Fix fmt. * Make `ChunkHash` fields public. * fix decompose function * update figures * clean up * address comments * add is_final checks * update readme * constraint hash input length * fix clippy --------- Co-authored-by: Akase Cho <[email protected]> Co-authored-by: Ho <[email protected]> Co-authored-by: Zhang Zhuo <[email protected]> Co-authored-by: kunxian xia <[email protected]> Co-authored-by: Steven Gu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tx_type info is lost during the type conversion between
bus_mapping::circuit_input_builder::Transactionandeth_types::geth_types::Transaction.Moreover, when we received a
ethers_core::Transactionwhosetransaction_typeis not properly set (i.e. it's set toNone), and if v = 0 it does not guarantee that this tx must bePreEip155tx. Because L1Msg also have v = 0 in this case.Therefore we need to check if (v, r, s) = (0, 0, 0), then tx is of type
L1Msg.Issue Link
This pr should fix the scroll-tech/scroll-prover#190 issue.
Type of change