Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Use vector for arguments #239

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Feb 14, 2024

I am pretty much making this change in all my PRs. So let's make it a separate PR :)

I will make a follow-up issue after merge with things that need to be decided once we resolved the other PRs:

  • Adapt documentation
  • If we want to deprecate the argc/argv ctor, we should do so

@seqan-actions seqan-actions added the lint [INTERNAL] signals that clang-format ran label Feb 14, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sharg-parser ✅ Ready (Inspect) Visit Preview Feb 14, 2024 10:08am

@seqan-actions seqan-actions removed the lint [INTERNAL] signals that clang-format ran label Feb 14, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signals that clang-format ran and removed lint [INTERNAL] signals that clang-format ran labels Feb 14, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signals that clang-format ran and removed lint [INTERNAL] signals that clang-format ran labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f91e17) 91.90% compared to head (bb67f43) 91.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   91.90%   91.94%   +0.04%     
==========================================
  Files          17       17              
  Lines        1618     1627       +9     
==========================================
+ Hits         1487     1496       +9     
  Misses        131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SGSSGene SGSSGene self-requested a review February 14, 2024 10:17
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@eseiler eseiler enabled auto-merge February 14, 2024 10:19
@eseiler eseiler merged commit 3b55514 into seqan:main Feb 14, 2024
33 checks passed
@eseiler eseiler deleted the misc/vector_ctor branch February 14, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants