#5837 Disappearing Navigation Bar #5959
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8b207d536e3b89b7d610ad226a479c0d14054944)
3 tasks
|
I'm not wild about adding this workaround. I can't trivially reproduce the issue on iOS 18.3 by rotating to landscape and back, so clearly something unreliable is going on. There's already a lot of unstable and hacky things already around Signal's nav bars, and I'm not inclined to add yet another instance without understanding the root cause. I worry that this will create more subtle problems down the line. |
| @@ -13,6 +13,12 @@ extension ConversationViewController { | |||
|
|
|||
| self.title = nil | |||
|
|
|||
| //HACK: If you look at issue #5837, the navigation title view is disappering. You can confirm this by looking at the view hierarchy; however, the navigation titleview says that its title view is not nil. Setting active breakpoints in this function prevents the bug from happening. I'm confident that this is a UIKit bug. To get around this we simply remove and add the headerview back again. This seems to only happen with iPad | |||
There was a problem hiding this comment.
Suggested change
| //HACK: If you look at issue #5837, the navigation title view is disappering. You can confirm this by looking at the view hierarchy; however, the navigation titleview says that its title view is not nil. Setting active breakpoints in this function prevents the bug from happening. I'm confident that this is a UIKit bug. To get around this we simply remove and add the headerview back again. This seems to only happen with iPad | |
| // HACK: If you look at issue #5837, the navigation title view is disappearing. You can confirm this by looking at the view hierarchy; however, the navigation titleview says that its title view is not nil. Setting active breakpoints in this function prevents the bug from happening. I'm confident that this is a UIKit bug. To get around this we simply remove and add the headerview back again. This seems to only happen with iPad |
| @@ -13,6 +13,12 @@ extension ConversationViewController { | |||
|
|
|||
| self.title = nil | |||
|
|
|||
| //HACK: If you look at issue #5837, the navigation title view is disappering. You can confirm this by looking at the view hierarchy; however, the navigation titleview says that its title view is not nil. Setting active breakpoints in this function prevents the bug from happening. I'm confident that this is a UIKit bug. To get around this we simply remove and add the headerview back again. This seems to only happen with iPad | |||
| DispatchQueue.main.async { [weak self] in | |||
There was a problem hiding this comment.
Do we really need [weak self] here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
This proposal
fixes #5837by provided a workaround the navigation bar disappearing. Exploring the codebase, there is no location where the navigation bar title view is hidden; however, as explained in the code comment in this PRs only commit, I am confident that this is a UIKit bug. This PR is a workaround until that UIKit bug is patched.