Refactor macOS worflow to include app signing and notarization#1145
Merged
Conversation
Member
|
I do not think we can validate the pull request without triggering the build of the frozen binaries. Does it have to be done with another PR or it is enough to change the version number to rc3 to trigger the build? |
Collaborator
|
Build of the frozen binaries (just for MacOS) is done in the fork. |
Collaborator
|
Is it OK that signed dmg is larger? 403mb vs 372mb in last pre-release (which i think was forked). |
Member
Author
|
I don't know why it is larger. |
Collaborator
|
Note: It was confirmed to be a working version - since it utilize slightly different packing procedure the differences in size could be ok. |
sergey-yaroslavtsev
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR refactors the macOS workflow and adds scripts to sign the app and notarize and staple the .dmg.