fix: don't discard optimized code when post-split perf estimate fails#451
Merged
dop-amin merged 1 commit intoJun 17, 2026
Merged
Conversation
dop-amin
requested changes
Jun 11, 2026
dop-amin
left a comment
dop-amin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR!
Functionally, the secondary objective timeout should also be un-set.
From a style point of view, I think getting rid of the duplicate warning and simplifying the code path can be worth it.
thisisjube
force-pushed
the
fix-split-perf-estimate-nonfatal
branch
from
933f314 to
b27c0a5
Compare
The performance estimate after the split heuristic runs another binary
search (`optimize_binsearch`), which raises `SlothyException` on failure
rather than returning `success=False`. That exception propagated up and
discarded the already-optimized code. It also inherited the optimization
timeout, so a too-short timeout would abort it.
Catch the exception (warn and keep the optimized code without a stall
estimate) and disable the timeout for the estimate, since it only inserts
stalls into the already-fixed ordering.
thisisjube
force-pushed
the
fix-split-perf-estimate-nonfatal
branch
from
b27c0a5 to
1c3ee0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance estimate after the split heuristic runs another binary
search (
optimize_binsearch), which raisesSlothyExceptionon failurerather than returning
success=False. That exception propagated up anddiscarded the already-optimized code. It also inherited the optimization
timeout, so a too-short timeout would abort it.
Catch the exception (warn and keep the optimized code without a stall
estimate) and disable the timeout for the estimate, since it only inserts
stalls into the already-fixed ordering.
Closes #96 @dop-amin