Skip to content

fix: don't discard optimized code when post-split perf estimate fails #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dop-amin merged 1 commit into from
Jun 17, 2026
Merged

fix: don't discard optimized code when post-split perf estimate fails #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions slothy/core/heuristics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,14 +961,21 @@ def not_empty(x):
conf2.constraints.allow_renaming = False
conf2.constraints.allow_reordering = False
conf2.variable_size = True
stall_res = Heuristics.optimize_binsearch(
res.code, logger.getChild("split_estimtate_perf"), conf2
)
if stall_res.success is False:
log.error(
"Stall-estimate for final code after split heuristic failed"
" -- should not happen? Maybe increase timeout?"
" Just returning the result without stall-estimate."
conf2.timeout = None
Comment thread
thisisjube marked this conversation as resolved.
conf2.retry_timeout = None
stall_res = None
try:
stall_res = Heuristics.optimize_binsearch(
res.code, logger.getChild("split_estimate_perf"), conf2
)
except SlothyException:
Comment thread
thisisjube marked this conversation as resolved.
pass

if stall_res is None or stall_res.success is False:
log.warning(
"Stall-estimate for final code after split heuristic"
" failed -- returning the optimized result without"
" stall-estimate."
)
else:
res2 = Result(conf2)
Expand Down
Loading