-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content: draft: define source-track objective in terms of revisions and provenance. #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zachariahcox
commented
Jun 28, 2024
zachariahcox
commented
Jun 28, 2024
TomHennen
requested changes
Jul 1, 2024
joshuagl
reviewed
Jul 3, 2024
fixes slsa-framework#1072 Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
zachariahcox
commented
Jul 10, 2024
zachariahcox
commented
Jul 10, 2024
zachariahcox
commented
Jul 10, 2024
zachariahcox
commented
Jul 10, 2024
zachariahcox
commented
Jul 10, 2024
TomHennen
reviewed
Jul 10, 2024
TomHennen
reviewed
Jul 10, 2024
TomHennen
reviewed
Jul 10, 2024
TomHennen
reviewed
Jul 10, 2024
TomHennen
reviewed
Jul 10, 2024
Co-authored-by: Tom Hennen <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Tom Hennen <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Tom Hennen <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Tom Hennen <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
TomHennen
requested changes
Jul 10, 2024
Co-authored-by: Tom Hennen <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
TomHennen
approved these changes
Jul 10, 2024
Signed-off-by: Zachariah Cox <[email protected]>
joshuagl
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits, but otherwise LGTM
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Zachariah Cox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1072
This PR modifies draft content of the slsa spec.
Context
Based on discussion from #1037
See discussion here.
Copied from draft proposal here.
Google document requires [email protected] membership.
Source revision provenance
Repos contain many revisions, most of which are not "official" or otherwise approved for release.
The goal of the source track is to attest to why a specific revision was approved for release.
We can think of the SCP / code review tool as “building” the next official revision of a repository using a codified process that involves collecting commits, acquiring reviews, running CI, etc.
If the change review process is successful, the code review tooling will merge the code changes and attest to the process used to produce the new revision.
The source provenance attestations associate a specific revision of a repository to security claims and documents (basically build logs) of the process that produced it.
In GitHub terms, a merged pull request and its associated rules evaluation justify why and how a specific git SHA is reachable from a protected branch.
Example Scenario