Preact: handle modal and html popup messages#2567
Open
ISenseAura wants to merge 1 commit intosmogon:masterfrom
Open
Preact: handle modal and html popup messages#2567ISenseAura wants to merge 1 commit intosmogon:masterfrom
ISenseAura wants to merge 1 commit intosmogon:masterfrom
Conversation
Zarel
reviewed
Mar 15, 2026
| } | ||
| } | ||
| PS.alert(message.replace(/\|\|/g, '\n')); | ||
| PS.alert(message.replace(/^(\|modal\||\|html\||\|wide\|)/, "").replace(/\|\|/g, '\n')); |
Member
There was a problem hiding this comment.
Should these not be handled inside PS.alert?
Member
Author
There was a problem hiding this comment.
we can if we want
but i think its better that we keep this outside PS.alert
those prefixes are protocol stuff so handling them outside of the function keeps PS.alert simple, as it is just a helper function to show the given message in a popup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.