Skip to content

Preact: handle modal and html popup messages #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ISenseAura wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preact: handle modal and html popup messages #2567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion play.pokemonshowdown.com/src/panel-mainmenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export class MainMenuRoom extends PSRoom {
room.update(null);
}
}
PS.alert(message.replace(/\|\|/g, '\n'));
PS.alert(message.replace(/^(\|modal\||\|html\||\|wide\|)/, "").replace(/\|\|/g, '\n'));
Copy link
Copy Markdown
Member

@Zarel Zarel Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these not be handled inside PS.alert?

Copy link
Copy Markdown
Member Author

@ISenseAura ISenseAura Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can if we want
but i think its better that we keep this outside PS.alert
those prefixes are protocol stuff so handling them outside of the function keeps PS.alert simple, as it is just a helper function to show the given message in a popup.

return;
}
}
Expand Down