feat: migrate turbo limits checks from SDK #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
changed the title
wa0x6e
force-pushed
the
feat-check-turbo-limits
branch
from
9f4e2f6 to
f07b724
Compare
ChaituVR
requested changes
Feb 3, 2025
ChaituVR
approved these changes
Feb 3, 2025
|
@wa0x6e Can we merge this? this is blocking all other PRs |
wa0x6e
added a commit
that referenced
this pull request
Feb 6, 2025
* feat: get turbo limits from database * refactor: fetch options from DB, without cache * fix: fix missing await * fix: fix wrong options name * feat: migrate turbo limits checks from SDK (#495) * feat: validate number of strategies depending on space type * feat: check proposal limits * refactor: avoid duplicate method calls * chore(deps): bump @snapshot-labs/snapshot.js from 0.12.45 to 0.12.46 (#499) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.45 to 0.12.46. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.45...v0.12.46) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chaitanya <[email protected]> * fix tests * Update src/writer/proposal.ts * fix lint and remove extra brace * Update src/writer/proposal.ts * perf: get limits with a single sql query * move getSpaceType after validateSpace --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Chaitanya <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/315
Depends on #494
After removing the turbo limits check in snapshot-labs/snapshot.js#1115 , this PR will add back those checks on sequencer side.
It will check for