Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logo to skin params #1120

Merged

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Feb 4, 2025

Toward https://github.com/snapshot-labs/workflow/issues/416
Depends on #1119

This PR will add a new logo property to the skinParams object, to store white label custom logo

@wa0x6e wa0x6e changed the title Feat-add-logo-to-space-skin-params feat: add logo to skin params Feb 4, 2025
@wa0x6e wa0x6e marked this pull request as ready for review February 4, 2025 17:43
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 3d38a9d into feat-add-colors-to-space Feb 5, 2025
4 checks passed
@ChaituVR ChaituVR deleted the feat-add-logo-to-space-skin-params branch February 5, 2025 04:10
ChaituVR pushed a commit that referenced this pull request Feb 5, 2025
* feat: add skin colors to space settings

* fix: rename property to skinfParams

* fix: rename to skinSettings to follow hub naming

* feat: add logo to skin params (#1120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants