Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly find definitions for variable declarations #240

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Properly find definitions for variable declarations #240

merged 1 commit into from
Feb 5, 2025

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Jan 31, 2025 •
edited
Loading

@mkaput mkaput requested a review from a team as a code owner January 31, 2025 13:29
@mkaput mkaput requested review from Arcticae and piotmag769 and removed request for a team January 31, 2025 13:29
This was referenced Jan 31, 2025
Merged
Merged
@mkaput mkaput force-pushed the spr/main/919fc6f0 branch from 9a41cdf to 74c5c51 Compare February 3, 2025 10:19
@mkaput mkaput force-pushed the spr/main/b6917664 branch from bd03727 to fd50b74 Compare February 3, 2025 10:19
@mkaput mkaput force-pushed the spr/main/b6917664 branch from fd50b74 to 778e95a Compare February 4, 2025 09:51
@mkaput mkaput force-pushed the spr/main/919fc6f0 branch from 74c5c51 to 6115aac Compare February 4, 2025 09:51
This was referenced Feb 4, 2025
Closed
Merged
Merged
Merged
Base automatically changed from spr/main/b6917664 to main February 4, 2025 12:14
@mkaput mkaput force-pushed the spr/main/919fc6f0 branch from 6115aac to 69df947 Compare February 4, 2025 12:41
This was referenced Feb 4, 2025
Merged
Merged
Draggu
Draggu reviewed Feb 4, 2025
View reviewed changes
src/lang/defs.rs Show resolved Hide resolved
src/lang/defs.rs Show resolved Hide resolved
@mkaput mkaput force-pushed the spr/main/919fc6f0 branch from 69df947 to 7d8a3a9 Compare February 4, 2025 13:20
@mkaput mkaput force-pushed the spr/main/919fc6f0 branch from 7d8a3a9 to 2488657 Compare February 4, 2025 13:24
@mkaput mkaput added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 7993b71 Feb 5, 2025
11 checks passed
@mkaput mkaput deleted the spr/main/919fc6f0 branch February 5, 2025 05:44
piotmag769
piotmag769 reviewed Feb 5, 2025
View reviewed changes
tests/e2e/hover/structs.rs
Comment on lines +256 to +259
hello::unhappy_cases
```
```cairo
fn non_existent_struct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work no?

tests/e2e/hover/paths.rs
Comment on lines +511 to +513
```
```cairo
fn constructor_with_path()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work no?

tests/e2e/hover/partial.rs
Comment on lines +40 to +43
hello
```
```cairo
fn main()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 left review comments

@Draggu Draggu Draggu approved these changes

@Arcticae Arcticae Arcticae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Goto definition does not work on pattern binding
4 participants
@mkaput @Arcticae @piotmag769 @Draggu