Find definition for member declarations, fix definition nodes, add SyntaxNodeExt::cast #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
requested review from
Arcticae and
integraledelebesgue
and removed request for
a team
This was referenced Feb 4, 2025
mkaput
force-pushed
the
spr/main/c00cbbc0
branch
from
d629721 to
cbae84c
Compare
mkaput
force-pushed
the
spr/main/c6ff00b1
branch
2 times, most recently
from
3dad970 to
de72e8d
Compare
mkaput
force-pushed
the
spr/main/c00cbbc0
branch
from
cbae84c to
f0d4cac
Compare
Draggu
approved these changes
Feb 4, 2025
mkaput
force-pushed
the
spr/main/c6ff00b1
branch
from
de72e8d to
3cd27f5
Compare
This was referenced Feb 5, 2025
…ntaxNodeExt::cast commit-id:c6ff00b1
mkaput
force-pushed
the
spr/main/c6ff00b1
branch
from
3cd27f5 to
e39ec88
Compare
mkaput
force-pushed
the
spr/main/c00cbbc0
branch
from
270d503 to
754ef51
Compare
piotmag769
approved these changes
Feb 5, 2025
piotmag769
reviewed
Feb 5, 2025
| db: &AnalysisDatabase, | ||
| identifier: &ast::TerminalIdentifier, | ||
| ) -> Option<MemberId> { | ||
| let member = identifier.as_syntax_node().parent()?.cast::<ast::Member>(db)?; |
There was a problem hiding this comment.
Smart, that's actually the only possible case lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
SymbolDef::Variantto fix finding references of enum variants #257