Skip to content

chore: fix fetching files in speech to text controller #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v0.4.0-rc1
Choose a base branch
from

Conversation

jakmro
Copy link
Member

@jakmro jakmro commented May 8, 2025

Description

  1. Change fetching files in speech to text controller.
  2. Use tokenizerModule in speech to text controller.
  3. Fix speechToText demo app. Add microphone permissions and rebuild the ios folder.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@jakmro jakmro requested review from mkopcins and chmjkb May 8, 2025 15:44
@@ -1395,7 +1395,7 @@ PODS:
- React-jsiexecutor
- React-RCTFBReactNativeSpec
- ReactCommon/turbomodule/core
- react-native-executorch (0.3.2):
- react-native-executorch (20250508171113):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't commit changes to lockfiles if you're not chaning dependencies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development artifact, but the version will need to be updated to v0.4.0 eventually

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but we don't want it on RC branch, please remove it

Copy link
Collaborator

@pweglik pweglik May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here? Is this change required for the new code to work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Native ExecuTorch v0.4.0 is required to run the code, so the dependencies will still need to be updated once v0.4.0 is released.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then will change it in commits before release, only update code changes relevant to PR - then we don't have to review it every time in every PR

@pweglik pweglik self-requested a review May 14, 2025 12:03
Copy link
Collaborator

@pweglik pweglik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove development artifacts

@jakmro jakmro requested a review from pweglik May 14, 2025 12:18
Comment on lines +47 to +48
<key>NSMicrophoneUsageDescription</key>
<string>This app needs access to your microphone to record audio.</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add similar thing for Android?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the android implementation was lacking microphone permission handling. I've added it.

@jakmro jakmro requested a review from pweglik May 15, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants