-
Notifications
You must be signed in to change notification settings - Fork 30
chore: fix fetching files in speech to text controller #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.4.0-rc1
Are you sure you want to change the base?
chore: fix fetching files in speech to text controller #274
Conversation
@@ -1395,7 +1395,7 @@ PODS: | |||
- React-jsiexecutor | |||
- React-RCTFBReactNativeSpec | |||
- ReactCommon/turbomodule/core | |||
- react-native-executorch (0.3.2): | |||
- react-native-executorch (20250508171113): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't commit changes to lockfiles if you're not chaning dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Development artifact, but the version will need to be updated to v0.4.0 eventually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but we don't want it on RC branch, please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here? Is this change required for the new code to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Native ExecuTorch v0.4.0 is required to run the code, so the dependencies will still need to be updated once v0.4.0 is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then will change it in commits before release, only update code changes relevant to PR - then we don't have to review it every time in every PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove development artifacts
<key>NSMicrophoneUsageDescription</key> | ||
<string>This app needs access to your microphone to record audio.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add similar thing for Android?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the android implementation was lacking microphone permission handling. I've added it.
Description
Type of change
Tested on
Checklist