-
Notifications
You must be signed in to change notification settings - Fork 30
chore: fix fetching files in speech to text controller #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakmro
merged 4 commits into
v0.4.0-rc1
from
@jakmro/fix-fetching-files-in-SpeechToTextController
May 16, 2025
+42
−27
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
examples/speech-to-text/android/app/src/main/AndroidManifest.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ import { | |
StyleSheet, | ||
SafeAreaView, | ||
TouchableOpacity, | ||
PermissionsAndroid, | ||
Platform, | ||
} from 'react-native'; | ||
import LiveAudioStream from 'react-native-live-audio-stream'; | ||
import SWMIcon from '../assets/swm_icon.svg'; | ||
|
@@ -75,6 +77,21 @@ export const SpeechToTextScreen = () => { | |
}; | ||
|
||
const handleRecordPress = async () => { | ||
if (Platform.OS === 'android') { | ||
const permission = await PermissionsAndroid.check( | ||
PermissionsAndroid.PERMISSIONS.RECORD_AUDIO | ||
); | ||
if (!permission) { | ||
const granted = await PermissionsAndroid.request( | ||
PermissionsAndroid.PERMISSIONS.RECORD_AUDIO | ||
); | ||
if (granted !== PermissionsAndroid.RESULTS.GRANTED) { | ||
console.log('Microphone permission denied'); | ||
return; | ||
} | ||
} | ||
} | ||
|
||
Comment on lines
+80
to
+94
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're not asking for permission on ios? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no, it's handled automatically |
||
if (isRecording) { | ||
LiveAudioStream.stop(); | ||
setIsRecording(false); | ||
|
@@ -162,7 +179,7 @@ export const SpeechToTextScreen = () => { | |
}} | ||
> | ||
<Text style={[styles.recordingButtonText, styles.font13]}> | ||
{'TRANSCRIBE FROM URL'} | ||
TRANSCRIBE FROM URL | ||
</Text> | ||
</TouchableOpacity> | ||
</View> | ||
|
@@ -226,6 +243,7 @@ const styles = StyleSheet.create({ | |
justifyContent: 'center', | ||
alignItems: 'center', | ||
marginBottom: 20, | ||
backgroundColor: 'white', | ||
}, | ||
recordingButtonWrapper: { | ||
flex: 1, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it now, but in future try not to include irrelevant changes like this caused by rebuilds that has nothing to do with changes mentioned in PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the relevant changes were actually autogenerated (build)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, changes in permissions can be autogenerated, but I see no reason to include formatting changes in kotlin in this PR. I'm not even sure why is this happening - it should have been properly formatted after expo update along with other files.
Anyway, I think these kind of changes should be limited to PRs related to bumping version of dependencies etc