feat: support for RN 0.78 #2626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description @kkafar: Fixes #2594 ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
## Description The `NativeViewHierarchyManager` argument in `.addUIBlock` is nullable. (See [`UIBlock::execute(...)`](https://github.com/facebook/react-native/blob/864c34e9f6c55319417633206e58cefc3c962e7d/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIBlock.kt#L12)) This PR fixes that definition and makes it nullable, and also checks for null. In our case, we likely want to exit out of that and just do nothing. (but lmk, I can also change to a throw) <!-- Description and motivation for this PR. Include Fixes #<number> if this is fixing some issue. Fixes # . --> ## Changes - Fixed `NativeViewHierarchyManager` being nullable <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]>
4 tasks
|
heyo - nice work! are you planning on releasing a beta for RN 78-rc support? Specifically the |
|
Hey, I expect support for 0.78 to be released first in beta of 4.8.0 (a month from now?). We still have only-latest-version-support policy for Fabric and I do not want to switch for 0.78 too early. |
|
ok, understood. thx I'm asking because that's the only thing blocking Nitro Views 😅 |
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Feb 4, 2025
## Summary Adds if checks for the RN 0.78 in native code, thanks to which package builds on both - 0.78 nd 0.77. ## Checklist - [ ] Upgrade `react-native-screens` when 0.78 support is added (software-mansion/react-native-screens#2626) - [ ] Upgrade `react-native-svg` when 0.78 support is added (software-mansion/react-native-svg#2619) - [ ] Upgrade `react-native-gesture-handler` when 0.78 support is added (software-mansion/react-native-gesture-handler#3354) - [ ] `react-native-pager-view` auto generated schema contains invalid `StringEnumTypeAnnotation` fields and crashes build on Android || Fabric (iOS) | Fabric (Android) | Web | MacOS (not upgraded) | TVOS (not upgraded) | |-|-|-|-|-|-| | Builds | ✅ | ✅ | ✅ | ✅ | ✅ | | Runs | ❌ | ❌ | ❌ | ✅ | ✅ | *Apps where RN was upgraded don't run because of incompatible dependency versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP WIP
Changes
Test code and steps to reproduce
Checklist