Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter changes #10625

Merged
merged 3 commits into from
Feb 17, 2025
Merged

linter changes #10625

merged 3 commits into from
Feb 17, 2025

Conversation

sheidkamp
Copy link

Description

Update .golangci.yaml to use valid structure

Copy link

@andy-fong andy-fong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume removing the skip-dirs is intentional?

@soloio-bulldozer soloio-bulldozer bot merged commit 9a001ee into main Feb 17, 2025
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sheidkamp/changes-for-linter branch February 17, 2025 19:00
@stevenctl
Copy link

Needs backported to 1.18 as well

sheidkamp added a commit that referenced this pull request Feb 17, 2025
sheidkamp added a commit that referenced this pull request Feb 17, 2025
@sheidkamp sheidkamp mentioned this pull request Feb 17, 2025
@sheidkamp
Copy link
Author

I assume removing the skip-dirs is intentional?

Yes, it is not a supported field, so was not having any effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants