Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tls tests should not ignore cert #10661

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

puertomontt
Copy link

@puertomontt puertomontt commented Feb 25, 2025

Description

noticed that tests were curling with IgnoreServerCert (-k) option. should just use the cert.

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

Visit the preview URL for this PR (updated for commit 745ce48):

https://gloo-edge--pr10661-puertomontt-tls-test-4foqtoeg.web.app

(expires Tue, 04 Mar 2025 22:02:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@soloio-bulldozer soloio-bulldozer bot merged commit e68f4bf into main Feb 25, 2025
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the puertomontt/tls-tests-secure branch February 25, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants