Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tls tests should not ignore cert #10661

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix: tls tests should not ignore cert #10661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a29e220
fix: tls tests should not ignore cert
puertomontt Feb 25, 2025
745ce48
cl
puertomontt Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/v1.19.0-beta13/tls-tests-secure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changelog:
- type: NON_USER_FACING
description: >-
"fix: tls tests should not ignore cert when curling"
1 change: 0 additions & 1 deletion test/kubernetes/e2e/features/services/tlsroute/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ func (s *testingSuite) TestConfigureTLSRouteBackingDestinations() {
curl.WithCaFile("/etc/server-certs/tls.crt"),
curl.WithScheme("https"),
curl.WithSni("example.com"),
curl.IgnoreServerCert(),
curl.VerboseOutput(),
},
tc.expectedResponses[i])
Expand Down
8 changes: 8 additions & 0 deletions ...kubernetes/e2e/features/services/tlsroute/testdata/multi-listener-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,11 @@ spec:
cpu: "100m"
limits:
cpu: "200m"
volumeMounts:
- name: server-certs
mountPath: /etc/server-certs
readOnly: true
volumes:
- name: server-certs
secret:
secretName: tls-secret
27 changes: 13 additions & 14 deletions test/kubernetes/e2e/features/services/tlsroute/testdata/tls-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,16 @@ type: kubernetes.io/tls
metadata:
name: tls-secret
data:
# Common Name: *
# Subject Alternative Names: *
# Organization: gateway
# Organization Unit:
# Locality:
# State:
# Country:
# Valid From: November 8, 2023
# Valid To: November 5, 2033
# Issuer: *, root
# Key Size: 2048 bit
# Serial Number: 0 (0x0)
tls.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVQVENDQWlXZ0F3SUJBZ0lCQURBTkJna3Foa2lHOXcwQkFRc0ZBREFiTVFvd0NBWURWUVFEREFFcU1RMHcKQ3dZRFZRUUtEQVJ5YjI5ME1CNFhEVEl6TVRFd09ERTJORFExTjFvWERUTXpNVEV3TlRFMk5EUTFOMW93SGpFSwpNQWdHQTFVRUF3d0JLakVRTUE0R0ExVUVDZ3dIWjJGMFpYZGhlVENDQVNJd0RRWUpLb1pJaHZjTkFRRUJCUUFECmdnRVBBRENDQVFvQ2dnRUJBTit0V2hoa3QvNVFQTUw4UGorZ1JScUM1blp5TG9Sem5iK3hPazdQTVozRndtYUcKNThvbVhPRm16ZmJlK0VaaGE0UlBhK1BpdFhFbitjZkM5allYRU42dGM1WExWUjlKK1dCRXRhSUpoZlh2VzAvbgpraEg0MWFZa2NCQVMyTEh1U3l4WWd3VERMRzI1OUxVdVJFT3VGSVhtWUZJaGVlZTZ6V3dRMXk0Ujk1VzRoVGFzCi9JVk9wYmttbSsyM0ZVQ1Q3RTcvNzN0RFh3Q1dpekc3UnUyZ1p2aS9tK0ZRVUJCZmFPTGxzelQvVHNwNTB3YmUKY0hxY29UbWJNWUJpWDk1RFBYTWtnZ2g5M1R2bnBWb0taYVZhWDNOdHlGRGJOZnEyLzZaT2daNFlNZVgzb0VMUgpiVllpY01rU3lZRHJWbW9jeHZBMWdQQUsxd2NkVE1OcjlnY0F1b0VDQXdFQUFhT0JpRENCaFRBSkJnTlZIUk1FCkFqQUFNQXNHQTFVZER3UUVBd0lGNERBZEJnTlZIU1VFRmpBVUJnZ3JCZ0VGQlFjREFnWUlLd1lCQlFVSEF3RXcKREFZRFZSMFJCQVV3QTRJQktqQWRCZ05WSFE0RUZnUVVxaW40SEhXN08wR3NLbGgwUEJ2SFFZSzRQT013SHdZRApWUjBqQkJnd0ZvQVVZb3l3TXpJN1BpWGtJd3FMSTdkNzA5SmJnVmN3RFFZSktvWklodmNOQVFFTEJRQURnZ0lCCkFCQ3p2NUUrb3hYT3RBUi9UWWE2YWJMVm94WENPWFZVeVFRell5VFJoekJOY0Vjbk1NeDBHc2V1NHRXeUlmem8KNmQ5LzRkOWdmdDlRNnVTS1RZUkhYU0VIQUFsMmlEWGdQTTZoSk0vNmpxQlE2N1ErVkVrUTJWVUMySDZEYjF1Qwo2VGdldk9MdlA1eDhrS2FjZVNnYTdmSHZJcW95OHVmbm1BSzlhd2ZobE9hajBjUWcxQXV6aW14blhzTVQvdkNVCm9Xa2xPZSt0TDA2OEd3LytIMFJQMTJ6N2t6VGJDbXZuRWU4bk1QSXNrU21NZTcvUnZLcUFuYTd0NHFDOVdyRXgKWlFZK0NlOVhrTnI3RGJaZnprTmpqUFV2OEozdHN2dzY5Zm1HcVBEWVpHMm1HQjRzeGFyNy9mZG4rbGd3MDVsRwpBbEhhaWpXTlVGTWtmcXgvUzZnampEL0NPZVpRcVltM1hLY3RCWkFSUjNJRUR0RWNEUkRzNllvczhCUTBzbS9ECkhnNG1XWWR4Y283WlpnUzF6ZWlhdkNwRWxDaXEzWnB5c0EvS1NLS056Y1RIRk5acXBxYWFNdVQvaTBuaUI1MmEKZmpFSDUzdk1wYXhUK1IvcFIxQ1NMREZ6VDI3OTFMaEprZkJWVWwzQkdnOVY2VCt6bkl1Nkk1aVU1RlZZbVl3UApubS9EYitncE9JalEyU0w5Wm1nVkNvdjFvNTBTU3ZLN1RYSFVIaXFoZXlucDAyR1ZYYXpFT295ODBWcG04dW9JCklvS2NFOS9IUldOT0F5Uk41cWtYRDBnalpJOWM1aUtjV25kQ1B1cnBFZENNZUdiems1cWRUNGhZSFFsM2RKeW8KNHJoZm9MN051R1VUa0o1ZCtGdFBwaXRISkNEVGdUb05LTVNGcTcxbzRoMXkKLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=
tls.key: LS0tLS1CRUdJTiBQUklWQVRFIEtFWS0tLS0tCk1JSUV1d0lCQURBTkJna3Foa2lHOXcwQkFRRUZBQVNDQktVd2dnU2hBZ0VBQW9JQkFRRGZyVm9ZWkxmK1VEekMKL0Q0L29FVWFndVoyY2k2RWM1Mi9zVHBPenpHZHhjSm1odWZLSmx6aFpzMzIzdmhHWVd1RVQydmo0clZ4Si9uSAp3dlkyRnhEZXJYT1Z5MVVmU2ZsZ1JMV2lDWVgxNzF0UDU1SVIrTldtSkhBUUV0aXg3a3NzV0lNRXd5eHR1ZlMxCkxrUkRyaFNGNW1CU0lYbm51czFzRU5jdUVmZVZ1SVUyclB5RlRxVzVKcHZ0dHhWQWsreE8vKzk3UTE4QWxvc3gKdTBidG9HYjR2NXZoVUZBUVgyamk1Yk0wLzA3S2VkTUczbkI2bktFNW16R0FZbC9lUXoxekpJSUlmZDA3NTZWYQpDbVdsV2w5emJjaFEyelg2dHYrbVRvR2VHREhsOTZCQzBXMVdJbkRKRXNtQTYxWnFITWJ3TllEd0N0Y0hIVXpECmEvWUhBTHFCQWdNQkFBRUNnZjhQVjFhUUwxaEVteTl0amc1WkR0SFFxRGFJZGZ0UUhwVmdCY0ZtMVVyZzBnSzAKWjZHa204V0REZ2ZqYlNlTlZ1RXhlRnFqV2RwWDkyeFhHbGNJdUV4SFgvZStsTXNRdnBWUllMcGhQblRuQU1YVgp0MG9rN1NYTFBVRll4OC8vcUcvWkZHTzA0UHJYNmFMRFNuZ0NBYXhxOFpNbFpFUkMyaUJKaTAwVXhGNHNKR25WCklJeHFLeVRnbWpBcFV6c1BDWXF5ci9aNmJTRkVnbVNxNzJobmt2Rm1PV3NYcldzRlZLY05iUUplWTRMMEJuWUsKWk5xODNmemt6ekpxbVh3OEVncWFPNlhWMmJtVmYrM1hSL3ViMDRGeXRya0Y5bE1JU0pWOUhkQmtRaGV2VzZhVApoSG5pblV6VkgyUlh4M1piYWw3ck1ZL0lOMWNmaFVlWm9BZDQ0ZGtDZ1lFQTh1bHorbXpPWXg0QVNnWUo0eVNICkdmc1VQeXpJUU9vaEVJQmtxMWNrUHJlbVhsdEdoWTcrRmtYYmh5cnVuOTRIREJJZWR0RWt0YjlZSDkvT0xNME8KK056TlhTYnlaQ3ZTa1U1ZlNNeUpDc3E3L01JTlVpNUxGN1FLQVF1ZXk3WDgvUGU3NHhFQ29hN1AvSlJkTnYrdgpjUnkyUEZOSlNGbTJGdkxGeDA4TDFWa0NnWUVBNjdxV3Q5dENpQ24zRXVPM2hEeFptZ3VSWU55Tk9TWkowdjR5Cm9zaXZ0WFl2ZGVYWGxGZWFWSEJtZG5vZUYrVTZ6TXpUQUY0d09jNmZpenpCMjlGVkxjWjJmTE5tWXc0RmxENFEKR0wzMHVJckQ5WXJraGZWZm85TW9aVHo2cWJnc0xQQnNZTXljelpFOThyb3dmZVp2MkUzQ1lRaDhOL1lGbXRmOQptWTViNFdrQ2dZQkQyc2pHQkl6bWpTUGhpYXhMWWhISFJTYlR1dXU1am0xc0VhR05aMHM5cGNsNGhDREFBRUNqCjhpR3ZzV04xRHUyREJyQ3gyaHhhRkxoR054dDkwazVEWUZLUm1lYU42dHZvTVM5V3c2UG9ldGRtZE1LSjJWcXEKcFdWQ0EzLzVRYjRJNEI4QS8raHZSOGpic29vVGFmc1ZLc01ST09hNHFpNitYRlM1SnpDVUNRS0JnRmZLN2tjYgpTZlFjYlFDRC90MG8vTlg2YVBLQ01iYVBJLytJM0tMenl6engvMHNSaHZDZ2o4SFMrdFkxTlBBQlY1emV5OWJmClBXYktKWEZkOTNVK3lWSjdEN1h4dXJnNWlLcGxVdWxrRmJpRk5lWkZERWMzMDU3WURidG1zcFJ6RzBEQmFodkQKR01NV3pOT1J0RzJ2WFFoYUxZS2wvbDE1S3kwNE5DTDBlaFBCQW9HQkFMK2RmaVFmUjhYVGMwMzF6R0xwQm1kdQpOMU81aDM1cUdIT0s4M25MY1VQSnhzc0JTSGVxNTZEVHBic3VMRjY0V1c2bk5KSWRwckdRLzNpOFZldzhDa05ZCmtXY2ZGWkdUTGM4b2g4Tkw4bWpiZGtITCs3M3ZuVy9FbEZRRDlWZTE3WWN0cEZKbUcwcVBSaFVWQzhkSG5RYnAKWXRMTTQxb01qQlQ3NUdjRjBZZ2wKLS0tLS1FTkQgUFJJVkFURSBLRVktLS0tLQo=
# Common Name: example.com
# Subject Alternative Names: www.example.com
# Organization: Example Inc., CN=example.com
# Locality: San Francisco, O=Example Inc., CN=example.com
# State: California, L=San Francisco, O=Example Inc., CN=example.com
# Country: US, ST=California, L=San Francisco, O=Example Inc., CN=example.com
# Valid From: Feb 25 20:53:56 2025 GMT
# Valid To: Feb 23 20:53:56 2035 GMT
# Issuer: example.com
# Key Size: 2048 bit
# Serial Number: 56FCC1423A5915960494615398843723E2148B56
tls.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURwakNDQW82Z0F3SUJBZ0lVVnZ6QlFqcFpGWllFbEdGVG1JUTNJK0lVaTFZd0RRWUpLb1pJaHZjTkFRRUwKQlFBd1p6RUxNQWtHQTFVRUJoTUNWVk14RXpBUkJnTlZCQWdNQ2tOaGJHbG1iM0p1YVdFeEZqQVVCZ05WQkFjTQpEVk5oYmlCR2NtRnVZMmx6WTI4eEZUQVRCZ05WQkFvTURFVjRZVzF3YkdVZ1NXNWpMakVVTUJJR0ExVUVBd3dMClpYaGhiWEJzWlM1amIyMHdIaGNOTWpVd01qSTFNakExTXpVMldoY05NelV3TWpJek1qQTFNelUyV2pCbk1Rc3cKQ1FZRFZRUUdFd0pWVXpFVE1CRUdBMVVFQ0F3S1EyRnNhV1p2Y201cFlURVdNQlFHQTFVRUJ3d05VMkZ1SUVaeQpZVzVqYVhOamJ6RVZNQk1HQTFVRUNnd01SWGhoYlhCc1pTQkpibU11TVJRd0VnWURWUVFEREF0bGVHRnRjR3hsCkxtTnZiVENDQVNJd0RRWUpLb1pJaHZjTkFRRUJCUUFEZ2dFUEFEQ0NBUW9DZ2dFQkFLQ2dQTVBQQWc0dXdUdnoKc3lWYnBVdk1vRGFmbnEvVGJQVzNpcU5EUyttUnkrdzhKWlgvNzkwTzNuNzdvYUJRd3o5QTdaazdza21nYjhNUwpRMGFod3ZPMzRnU0tHamwrVXQySllTL3JXNmdLTWJmUjVDNWhPVzRTbVhCTzJDWFErRk8rZm53K1VSanhWUFN1ClArcEtrTWhBVnBSdlZQZmZYMm1lT05INjN0V05aWnBGaDRvQVE4YStpMUFiZXE3VGxvOE1XRFowdHJLVGlrQnYKSUN2S1FuYi8xbjN1eEdQaytJYjZtSHZSQ0NyK2NFZ1FVNURnR1lZQ3k4cllabythRXpCQzdkTXBDdXJtZnVvZgpXSzBvbFF2UytQWXpyc0hyeFBERGY5cHB0WUg4T25uRm4zTHJoSGd0OEVOVWh4Zjhjd2lYS0Y0cVlqT2p4NWJECkdaME5kWEVDQXdFQUFhTktNRWd3SndZRFZSMFJCQ0F3SG9JTFpYaGhiWEJzWlM1amIyMkNEM2QzZHk1bGVHRnQKY0d4bExtTnZiVEFkQmdOVkhRNEVGZ1FVOXdtUUpQYnBpV1dieXZneFZ3WHNMSkxsU1Jvd0RRWUpLb1pJaHZjTgpBUUVMQlFBRGdnRUJBQzhaZjA0MnlhVHFnZXpiTjZrL1lObG1MWnBWTWNUaytMajF4VXh3Y2xQRFM2ZmZPaytaCnZOajArNXFIb3U1Y05CUHlvY2FhVU52MWZPcndNMCtKZTJNZytQM25NT3Bia0RvcHhsUXQvS2N2eGJQVFJnazgKYzlaaE10T3ZlR2E4b3JIRHQrQTNaVXpwUEdiUHZwRzZDU1FWR0JnMjFrb0JCMzIzVVdjUzNQRE9iWmNLN0sySgpBYWJHbHU3bHdSazlFRDkyWEVCL3o4TDJ3TmduQjFlajhvV2ZUSS9wT0NKMEs2MnVBemVKQTI3ZUZxUGs0azdNCmY2Y3lHRjQxRzdQUnVPT2pxNmNmTGd5YVAvLzlhdWh5U2JSVlhJWG1kWTQzZ0czaWpoR2xNNXlXVEx5cVFWYUMKUVk4M0d5OXNERmN1OWgrbm1mUHpWdWpkQ2wwb29ZNmY2RkU9Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
tls.key: LS0tLS1CRUdJTiBQUklWQVRFIEtFWS0tLS0tCk1JSUV2Z0lCQURBTkJna3Foa2lHOXcwQkFRRUZBQVNDQktnd2dnU2tBZ0VBQW9JQkFRQ2dvRHpEendJT0xzRTcKODdNbFc2Vkx6S0EybjU2djAyejF0NHFqUTB2cGtjdnNQQ1dWLysvZER0NSsrNkdnVU1NL1FPMlpPN0pKb0cvRApFa05Hb2NMenQrSUVpaG81ZmxMZGlXRXY2MXVvQ2pHMzBlUXVZVGx1RXBsd1R0Z2wwUGhUdm41OFBsRVk4VlQwCnJqL3FTcERJUUZhVWIxVDMzMTlwbmpqUit0N1ZqV1dhUlllS0FFUEd2b3RRRzNxdTA1YVBERmcyZExheWs0cEEKYnlBcnlrSjIvOVo5N3NSajVQaUcrcGg3MFFncS9uQklFRk9RNEJtR0FzdksyR2FQbWhNd1F1M1RLUXJxNW43cQpIMWl0S0pVTDB2ajJNNjdCNjhUd3czL2FhYldCL0RwNXhaOXk2NFI0TGZCRFZJY1gvSE1JbHloZUttSXpvOGVXCnd4bWREWFZ4QWdNQkFBRUNnZ0VBQWVwQlYvQk56UGczQWg3TG5CWEhMbmRhNlVqbTBQenVQQmRoSFZFRDBEci8KT1lIbktlaGtvSWx6VFJ0ZUEzNTd2TGtOaXJENW11d0hDUmU1cGlqdkJnSWdhOURqaE1wVGw5NDN0dzI1OFdRaApYQ29tWUFoR3QwakxIdnlxWTVzM05sMTdoQWZoenhranJWZzZnQ0JVdkUwRWI1cjdISE5EbWQwS0Q5ZVJEQVhVCmEybVBvMy9zeCs2aktOdm1nbkhVNW1HYTByYTlYOWdWMmorcXkrRkwwWW1jWEphOXYwam9vTUJtck5LUTl1MEUKbFpIQ3Jod3o1Zm5WOEg1SWs5STJFc0JlV083RDBtSjErZjZiU0xkNFRjNWlpdGtLbUprU0N1Wks4bWhjWW1PTAozcFdleXcvTTFWcmdCU3Y3UnBnK2ZXUUl5WSsvN0pqMDhrY2Ryaml2MVFLQmdRRGV3TmZNQXMrSndrbDNsRzVRCkhxUXdlcEIrdGNIdlJtaE5BQVhpN0xhbWFMQ3EvcDVaVlVOa1hNTFljZG5CTWpzd2ZwM0dmVzFvWXh0cU1JWWIKU3lrSzgyNloyeG05UlpLd2loWDNzOUlBR3ZzSkFsampmOWZTa2JjU29CYmNjVnhMaGhTU05QTkxHRUVkdDY2QQpCTGlJM1ByK0NHaUZUZDFveDB5M1drY3BPd0tCZ1FDNG1aT1NmcHM3L0Qra2w2MUJCdW9nS2oxeGN4Uzk4RHVaCjVGTTJxZE1hN3hMRkNDdlNYempwOTR0ZGQ2eG9saDhPc0J0WlVwbXRhZzZ4OFpQTUhKbGxOVVNzYTU0Y3YvT2gKeVgzNzlSSDdFbFdMYVkwdHFuNU9pUDZvSnAvWm41MUI2MCtBaGg5V0NWRXhlK1JQVXE5NE51QXFTZWZicHVpUQpVejFVY3daUlF3S0JnUUNuTmtQSDFXUk5tUmJsT1BzR0VicFcyZXFWODRLOVJ6RU1mRFB2QUpxcm1ITG1LWFJjCnd2QnY2bUlwY0cxeDVXOGhIQ3I3MFRQTDVIbXo0UEVLbEFVZlAxV0xFVG5sSnREU3pSVm9lQWZ3SkZERmxvbDcKWFlCNWhRRFVibkE2MHEzaDA2aWxpRElKOFE4UWE4NEdNNFVDMkQ5aGFwWnJXdVFWdjJZTFRTMlYrUUtCZ0ZvcAoyT1J5cGt1ME56bWpRK0pCQ0ZYUmk5VS95bC9EV0xrZnhtMHFvWXZFUGJ5eTh3UjdzZ2JFKy9NWklzS3FvRnpDCk0zbDdXTWhVeHZ5dTYrdUVCSUJrZGpocEQvOG0yazZwWmJtTXg4MkQ5UGgxQTVuTWJvalpiTmlnbE83c2dSalQKWUM5OFV3M28yeGw2VTlkU29aWHI1NjJBRDVrL2V0UVRkQjh0VjJhVkFvR0JBSjBraHpPWHdPNE5DeHZhMlQ1QQo1bFJNSXJwS0NZZXd3am1VaEhOczFWejc3cFVVMG9QNFd3UmxBWHZkdUhuTjNRb3RZQTZPQ1laMXZOUkJsK3JlCk0xU0dxTFpVWjVxa0s3enphelNXRU80TDhOR2NOeXBOUHlSakpKWjh5TXRiSGpuT1VWNWJZSlZPNXcvMFJxaWYKUFpCRXg3UDhpZWZhZVVGbWs2OXRKZW1DCi0tLS0tRU5EIFBSSVZBVEUgS0VZLS0tLS0K
Loading