Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install TF on doc workflow #597

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: install TF on doc workflow #597

merged 1 commit into from
Jan 23, 2025

Conversation

eliecharra
Copy link
Member

@eliecharra eliecharra commented Jan 23, 2025

Description of the change

Terraform binary has been removed from ubuntu-latest, so let's install
it in our pipeline.

I also pinned TF version used in all workflows to avoid surprises.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

Terraform binary has been removed from ubuntu-latest, so let's install
it in our pipeline.

I also pinned TF version used in all workflows to avoid surprises.
@eliecharra eliecharra requested a review from a team January 23, 2025 09:52
- name: Install Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.10.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally wouldn't pin it so that we don't need to maintain it 🤷 I'd let it break

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather prefer to pin stuff, and handle controller upgrades with dependabot or renovate to avoid the pain of maintaining that ourselves.

I hate when a workflow became suddenly broken because some time has been elapsed since. A bit like what's happening right now because we relied on TF binary bundled with ubuntu-latest.

I can configure dependabot for taking care of bumping on new minors if you think it's worth it!

Copy link
Contributor

@peterdeme peterdeme Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Yeah, I'm typically on the opposing side, I prefer breaking stuff and fixing them rather than maintaining :) Mainly because in my experience no one ever maintains things unless they break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You like to embrace the dark side 🥷

@eliecharra eliecharra merged commit e73968a into main Jan 23, 2025
7 checks passed
@eliecharra eliecharra deleted the fix/doc_ci branch January 23, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants