Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install TF on doc workflow #597

Merged
merged 1 commit into from
Jan 23, 2025
+8 −0
Merged

fix: install TF on doc workflow #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/check-documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ jobs:
uses: actions/setup-go@v5
with: { go-version-file: go.mod }

- name: Install Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.10.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally wouldn't pin it so that we don't need to maintain it 🤷 I'd let it break

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather prefer to pin stuff, and handle controller upgrades with dependabot or renovate to avoid the pain of maintaining that ourselves.

I hate when a workflow became suddenly broken because some time has been elapsed since. A bit like what's happening right now because we relied on TF binary bundled with ubuntu-latest.

I can configure dependabot for taking care of bumping on new minors if you think it's worth it!

Copy link
Contributor

@peterdeme peterdeme Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Yeah, I'm typically on the opposing side, I prefer breaking stuff and fixing them rather than maintaining :) Mainly because in my experience no one ever maintains things unless they break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You like to embrace the dark side 🥷

terraform_wrapper: false

- name: Generate documentation
run: cd tools && go generate ./...

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- name: Install Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.10.5"
terraform_wrapper: false

- name: Test with coverage (prod - just checking it will works, no env missing etc)
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
- name: Install Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.10.5"
terraform_wrapper: false

- name: Test with coverage
Expand Down
Loading