Revise RedisCache and documentation #2051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now accept a byte array as pattern for scan operations in addition to String patterns. Also, use binary Jedis scan method to avoid bytes to String conversion. Closes #2006
We now support a configurable BatchStrategy for RedisCache. The implementations consist of KEYS (default) and SCAN. Since SCAN is not supported with Jedis Cluster and SCAN requires a batch size, we default to KEYS. Closes #1721.
spring-projects-issues
added
the
status: waiting-for-triage
...and use long return type instead of int for cleanCache.
mp911de
commented
May 18, 2021
| * @author Christoph Strobl | ||
| * @since 2.6 | ||
| */ | ||
| public abstract class BatchStrategies { |
There was a problem hiding this comment.
Let's add a private constructor.
|
Looks good, let's continue with a merge after adding the private constructor. |
christophstrobl
pushed a commit
that referenced
this pull request
May 20, 2021
Original Pull Request: #2051
christophstrobl
added a commit
that referenced
this pull request
May 20, 2021
...and use long return type instead of int for cleanCache. Original Pull Request: #2051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchStrategyto cleanup the cache viaKEYSorSCAN(supersedes DATAREDIS-1151 - Provide an example of using scan as an option in RedisCache #547, closes DefaultRedisCacheWriter.clean() uses blocking KEYS command [DATAREDIS-1151] #1721)ScanOptions(closes Cannot scan binary keys with Jedis #2006)